Return Type Hints Improvements#5
Conversation
| string $branchId, | ||
| string $workspaceId, | ||
| array $requestBody, | ||
| int $maxWaitSeconds = self::DEFAULT_MAX_WAIT_SECONDS, |
There was a problem hiding this comment.
mimo jiné jsem tu přidal nastavitelný čas na čekání na query
| } | ||
| } | ||
|
|
||
| /** @phpstan-ignore-next-line */ |
There was a problem hiding this comment.
co se tady ignoruje? vypadá to, že už je to všechno zkontrolovaný
There was a problem hiding this comment.
array{queryJobId: string, status: string, statements: array<array<string, mixed>>, results: array<array{columns: array<array{name: string, type: 'text'}>, data: array<array<int, string>>, status: string, rowsAffected: int}>} - should return
array{queryJobId: string, status: 'completed', statements: mixed, results: array<int<0, max>, array{columns: array<int, array{name: string, type: 'text'}>, data: array<array<int, string>>, status: string, rowsAffected: int}>} - but returns
There was a problem hiding this comment.
nojo, tak to je ale fixnutelny, on to nebere, protože tady je to celý v ifu https://github.com/keboola/query-api-php-client/pull/5/files#diff-40d7473316ef0bb3ba4c4d937b16ae3d1cc47e0d65815034ee2b5be6a74cb11eR241 kterej nevyhodí invalid response
| assert(isset($row[0]) && is_string($row[0])); | ||
| $this->assertArrayHasKey(0, $row); | ||
| $this->assertIsString($row[0]); | ||
| $this->assertNotEmpty($row[0]); |
There was a problem hiding this comment.
btw tohle všechno má bejt self:: to jsou ty generátory 🙄
ondrajodas
force-pushed
the
ondra-improvements
branch
from
f34596d to
fcafebf
Compare
ujovlado
force-pushed
the
ondra-improvements
branch
from
fcafebf to
9bf9729
Compare
3 participants
https://github.com/keboola/ai-service/pull/416#discussion_r2297516661