Skip to content
This repository was archived by the owner on Sep 5, 2025. It is now read-only.

Initial version php Query API PHP Client#1

Merged
ujovlado merged 23 commits into
mainfrom
ujovlado-init
Aug 20, 2025
Merged

Initial version php Query API PHP Client#1
ujovlado merged 23 commits into
mainfrom
ujovlado-init

Conversation

@ujovlado
Copy link
Copy Markdown
Contributor

@ujovlado ujovlado commented Aug 19, 2025

Jira: https://keboola.atlassian.net/browse/PAT-696

Changes:

  • Kick-off initial implementation of Query API PHP client. This client will be used in AI service.

Details

  • Client is dummy and does not do much right know (v0.1.0)
  • Storage API client is required only in dev environment (so I can create Workspace, Branch, etc.)
  • We released new version of Service Client, which is not needed at the end 😇 Add Query Service to Service Client platform-libraries#412
  • Env vars are simple, you just need to specify Storage API URL+token and Queue API Service URL (this enables various combinations)
  • There are 2 functional tests files - one for testing basic stuff, another one for more advanced.
  • Query Service is not 100% stable yet, we'll be updating tests and adding new functionality
  • There's also middleware adding required headers (everywhere except for health-check)

Comment thread Dockerfile Outdated
Copy link
Copy Markdown
Member

@MiroCillik MiroCillik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice kick-off 💪

I would use service-client and HOSTNAME_SUFFIX for obtaining the service(s) url.

I will approve once the service is working and the tests are passing :)

Comment thread src/Client.php Outdated
Comment thread Dockerfile Outdated
Comment thread src/Client.php Outdated
@ujovlado ujovlado marked this pull request as ready for review August 19, 2025 16:05
Copy link
Copy Markdown
Member

@MiroCillik MiroCillik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, len ten jeden test je tam zbytony

Comment thread tests/ClientTest.php Outdated
@ujovlado ujovlado merged commit bb5bcb6 into main Aug 20, 2025
1 check passed
@ujovlado ujovlado deleted the ujovlado-init branch August 20, 2025 05:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants