PAT-1795 Bump staging-provider and job-queue-job-configuration#803
Open
pepamartinec wants to merge 1 commit into
Open
PAT-1795 Bump staging-provider and job-queue-job-configuration#803pepamartinec wants to merge 1 commit into
pepamartinec wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
https://linear.app/keboola/issue/PAT-1795/switch-job-snowflake-workspace-to-always-use-logintype-snowflake
staging-providerupdate: PAT-1795 Drop default loginType from staging-provider workspace options platform-libraries#502job-queue-job-configurationupdate: https://github.com/keboola/job-queue/pull/706Bumps
keboola/staging-providerto^12.2.1andkeboola/job-queue-job-configurationto^3.5.0to pick up the unconditionalsnowflake-service-keypairauth for Snowflake staging workspaces, and theloginTypeplumbing simplification on theWorkspaceProviderside.No source changes required in
docker-bundleitself —Runner.phpwires up the sameWorkspaceProviderandStagingWorkspaceFactoryconstructors, which are unchanged.Plans for customer communication
None.
Impact analysis
No end-user impact in this PR. The behavior change (Snowflake workspaces now using keypair auth) is delivered by the upstream library bumps. Downstream DIND jobs picked up via
job-runnerwill get keypair-credentialed workspaces from this point on;WorkspaceWithCredentialsalready exposesprivateKeyso the runtime is ready.Change type
Maintenance
Justification
PAT-1795 — pick up unconditional Snowflake keypair auth.
Deployment
Merge & automatic deploy.
Rollback plan
Revert of this PR.
Post release support plan
None.