Add manage:delete-sandbox-workspaces command#92
Open
jirkasemmler wants to merge 4 commits into
Open
Conversation
Adds a new CLI command that deletes keboola.sandboxes workspaces in a project or organization. It pulls the workspace list from Connection, skips any workspace whose schema still has an active session in the Editor Service, then deletes the workspace configuration followed by the workspace itself for the remaining ones. Scoped by --project-id or --organization-id (mutually exclusive), filtered by a creation-date window, with --force gating real deletions and verbose per-workspace logging in dry-run as well. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds a new CLI maintenance command to identify and (optionally) delete keboola.sandboxes workspaces that have no active Editor Service session, scoped by project/organization and a creation-date window.
Changes:
- Introduces
manage:delete-sandbox-workspaceswith--project-id/--organization-id,--created-after/--created-before, and--force(dry-run default). - Implements per-project branching traversal, session-by-schema matching, and deletion order (configuration trash+purge → workspace) with summarized reporting.
- Registers the new command in the CLI application bootstrap.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Keboola/Console/Command/DeleteSandboxWorkspaces.php | New command implementation: discovery, filtering, session matching, deletion, and reporting. |
| cli.php | Registers the new command in the application. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+361
to
+369
| } catch (StorageClientException $e) { | ||
| if (str_contains($e->getMessage(), 'not found')) { | ||
| $output->writeln(sprintf( | ||
| ' Configuration %s/%s already gone', | ||
| self::COMPONENT_ID, | ||
| $configurationId, | ||
| )); | ||
| $configDeleted = true; | ||
| } else { |
| (string) $workspaceId, | ||
| $createdStr, | ||
| )); | ||
| $projectSkippedComponent++; |
odinuv
reviewed
May 21, 2026
| $editorClient = new EditorServiceClient($editorUrl, $storageToken['token']); | ||
|
|
||
| // Index editor sessions by workspaceSchema for O(1) lookup against workspace credentials. | ||
| $sessionsBySchema = []; |
Member
There was a problem hiding this comment.
hypoteticky muzes narazit na session, ktera WS nema, protoze se zrovna vytváí, ale nemyslím si, ze by to tady neco rozbilo
odinuv
reviewed
May 21, 2026
| } | ||
|
|
||
| if ($configurationId === '') { | ||
| $output->writeln(sprintf( |
Member
There was a problem hiding this comment.
no jestli jsou pro komponentu keboola.sandboxes a současně ta konfigurace neexistuje, tak bych je smazal ne? co s nima.
odinuv
reviewed
May 21, 2026
|
|
||
| class DeleteSandboxWorkspaces extends Command | ||
| { | ||
| private const string COMPONENT_ID = 'keboola.sandboxes'; |
Member
There was a problem hiding this comment.
a tak pojďmě přihodit ještě keboola.snowflake-transformation
Member
There was a problem hiding this comment.
ono je asi ne zvážení jestli to nedát configurovatelný a s defaultem na keboola.sandboxes anebo chceš dělat ještě nějakej další command?
odinuv
reviewed
May 21, 2026
| null, | ||
| InputOption::VALUE_REQUIRED, | ||
| 'Only consider workspaces created at or after this date ' | ||
| . '(strtotime expression, e.g. "-30 days", "2026-01-01"). Default: "-30 days".', |
Member
There was a problem hiding this comment.
to jsou takový divný defaulty - je to spíš naopak, ty měsíc starý asi jako mazat nechceš
- Make --component configurable (default keboola.sandboxes); empty value permitted so workspaces with no component can be targeted. - Enrich SKIP/DELETE log lines and the per-project candidates listing with component, configurationId, loginType and owner email (from creatorToken.description), falling back to "(none)" when absent. - Override the active-editor-session SKIP when the workspace points at a configurationId that no longer exists: GET the config, treat 404 as a stale session, log a NOTICE and proceed to delete the workspace.
The earlier SKIP for empty configurationId already returns, so the nested check inside the active-session branch was unreachable as false.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manage:delete-sandbox-workspacesCLI command that cleans upkeboola.sandboxesworkspaces in a project (--project-id) or across an entire organization (--organization-id).connection.schema; workspaces with an active session are skipped. The rest are deleted in the order configuration → workspace (configuration deleted twice = trash + purge, matching existing cleanup commands).--created-after/--created-before, default-30 days→now) and gated by--force(dry-run by default). Verbose per-workspace logging always on, plus per-branch / per-project / final summaries with skip-reason breakdown.Test plan
php cli.php manage:delete-sandbox-workspaces --helpshows the new options--project-id) and inspect the candidate list and skip-reason counts--organization-id)--forceagainst a throwaway project and verify configs + workspaces disappear and active-session workspaces are untouched🤖 Generated with Claude Code