android: clearer warnings on the unsupported device screen#574
Open
thisisAcidic wants to merge 1 commit intokavishdevar:mainfrom
Open
android: clearer warnings on the unsupported device screen#574thisisAcidic wants to merge 1 commit intokavishdevar:mainfrom
thisisAcidic wants to merge 1 commit intokavishdevar:mainfrom
Conversation
e1c2ef0 to
059b167
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the unsupported device screen right now just says "Not supported" and lists what works, but doesnt actually tell people their device wont work or to stop reporting it. people bypass, app fails as expected, then they open issues we cant do anything about. this just makes the screen blunt about it.
what changed
three strings in res/values/strings.xml:
not changed
values-zh-rTW/strings.xml still has the old weaker chinese translations. didnt touch them since i dont speak chinese. either keep as-is or remove those four entries so it falls back to english (which now has the new strict text). lmk if you want me to do something there