android: avoid double sendPause when both AirPods are removed at once#572
Open
thisisAcidic wants to merge 1 commit intokavishdevar:mainfrom
Open
android: avoid double sendPause when both AirPods are removed at once#572thisisAcidic wants to merge 1 commit intokavishdevar:mainfrom
thisisAcidic wants to merge 1 commit intokavishdevar:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When both ear detection bits flip from in to out in one packet, sendPause gets called twice. Once with force=true in the upper branch, then again at the bottom block. The second call is usually a no-op since music is already paused, but a timing race is possible.
This might affect #153, but no idea as i cant seem to reproduce it. Its a code cleanup atleast.