Added Qt Installer Framework#314
Open
KOLANICH wants to merge 1 commit intokaitai-io:masterfrom
Open
Conversation
| Qt installer framework is a set of libs to make SFX installers. Installers usually contain 7zip-compressed archives. Obviously, Qt installer itself is built using this framework. | ||
|
|
||
| Warning 1: KSC has a bug. It makes the computed values be int32_t. Of course their type should be either explicitly specified by a programmer or derived automatically. The workaroind is to just replace all int32_t to int64_t in sources. | ||
| Warning 2: don't use this spec on Linux against Qt distribution with overcommit enabled unless you have lot of RAM (> 12 GiB). There is a severe memory leak somewhere (currently I have no idea where exactly). The leak is present in both C++ and python-compiled code. In python even if I have patched the generated source to explicitly free all the `bytes`, `BytesIO`s and `KaitaiStream` objects the leak is still present. At least it is neither in `bytes` nor in `BytesIO`. In C++ I have not patched anything but used move semantics to free the stuff since std::unique_ptr is used. The leak is still present. IDK where it is and how to fix it. |
Member
There was a problem hiding this comment.
Can you please wrap the long lines to be at most 80 characters long, as the KSY Style Guide recommends?
Lines should be wrapped to be 80 columns long. If it doesn’t fit into single line after wrapping, then it’s a multi-line docstring, so use proper multi-line syntax.
Contributor
Author
There was a problem hiding this comment.
I am against manual wrapping. Instead wrapping must be done by a text editor depending on window size.
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
34ab09f to
b2ac983
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
b2ac983 to
bd0ef27
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
bd0ef27 to
6ce2b88
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
6ce2b88 to
218dc72
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
218dc72 to
e0cc3ec
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
e0cc3ec to
30fa220
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
30fa220 to
7750b88
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
2 times, most recently
from
b6d0770 to
2e7ea60
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
2e7ea60 to
5a48c95
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
3 times, most recently
from
66046ab to
be4f31a
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
be4f31a to
a05ebc6
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
2 times, most recently
from
dedbe78 to
89f2ab9
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
2 times, most recently
from
f15c126 to
43f4931
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
43f4931 to
675dc3d
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
3 times, most recently
from
0185a7f to
ec15491
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
ec15491 to
fbb0664
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
fbb0664 to
95ff28f
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
2 times, most recently
from
37ba021 to
9cee143
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
2 times, most recently
from
d9aa1dc to
3a0553a
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
2 times, most recently
from
5f1d675 to
4b1c257
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
4b1c257 to
052336d
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
052336d to
fc8dac2
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
fc8dac2 to
750657d
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
750657d to
9d40555
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
9d40555 to
2b1ea4d
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
2b1ea4d to
8b3bf55
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
8b3bf55 to
bc77a91
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
bc77a91 to
55526ce
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
55526ce to
3dc2279
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
2 times, most recently
from
8fb22dc to
04b2b3e
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
04b2b3e to
cde8a7d
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
cde8a7d to
e99f6cc
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
e99f6cc to
a8d25c6
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
a8d25c6 to
afda369
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
afda369 to
874dfa0
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
874dfa0 to
2e14e10
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
2e14e10 to
e7b98d8
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
2 times, most recently
from
7188255 to
34ba365
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
2 times, most recently
from
19aba8a to
9b28feb
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
9b28feb to
9d990a9
Compare
KOLANICH
force-pushed
the
qt_installer_framework
branch
from
9d990a9 to
39992b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since my PR into QIF repo was ignored for years, it seems they are both disinterested in maintaining the spec and disrespectful enough to just ignore PRs. So I post the spec here.
Fixes: #225