fix: mobile nav polish — stable toggle position, menu closes on all navigation#100
Merged
Conversation
The hamburger glyphs ☰ and ✕ have different advance widths, so the button box resized on toggle and pushed the right-aligned theme toggle sideways. Give the menu button a fixed square box (size-8) with the glyph centered; both controls now hold their position. Co-authored-by: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
kaiiiichen
changed the title
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two mobile nav fixes:
size-8square with the glyph centered. Measured at 375px viewport: theme toggle stays at x=287.01, menu button at x=317.41 across open/close cycles (0px shift).Test plan
npm run lint/npm run typecheck/npm run test(23) /npm run build🤖 Generated with Claude Code