fix: add openshell.io/sandbox-id annotation to sandbox pods#9
Merged
Conversation
The gateway's K8s SA authenticator looks up the sandbox identity from annotation openshell.io/sandbox-id on the pod, not the label openshell.ai/sandbox-id. Add the annotation to podTemplate metadata so IssueSandboxToken succeeds after TokenReview. The existing label is kept for backwards compatibility. Fixes: kagenti/kagenti#1815 Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
openshell.io/sandbox-idannotation to sandbox pod metadata so the gatewaycan look up the sandbox identity during
IssueSandboxToken.Problem
The gateway's K8s SA authenticator (
openshell-server/src/auth/k8s_sa.rs) expects:openshell.io/sandbox-id(domain:openshell.io)The driver was only setting:
openshell.ai/sandbox-id(domain:openshell.ai)This caused
IssueSandboxTokento fail after the TokenReview succeeded (rc.3).Changes
annotationSandboxID = "openshell.io/sandbox-id"constantpodTemplate.metadata.annotationsTestBuildSandboxSpec_AnnotationsFixes: kagenti/kagenti#1815
Test plan
go test ./...)Assisted-By: Claude Code