feat: inject projected SA token volume into sandbox pods#8
Merged
Conversation
The gateway's K8s SA authenticator requires tokens with audience "openshell-gateway". Replace the default SA token path with a projected serviceAccountToken volume so the supervisor authenticates correctly via IssueSandboxToken. Changes: - Add SATokenAudience/SATokenTTLSecs config fields and CLI flags - Add projected volume with configurable audience and TTL - Mount at /var/run/secrets/openshell/token (read-only, mode 0400) - Update OPENSHELL_K8S_SA_TOKEN_FILE to the new path Fixes: kagenti/kagenti#1815 Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serviceAccountTokenvolume with audienceopenshell-gatewayto sandbox pods/var/run/secrets/openshell/token(read-only, mode 0400)OPENSHELL_K8S_SA_TOKEN_FILEfrom default K8s SA path to the projected token path-sa-token-audience(defaultopenshell-gateway),-sa-token-ttl-secs(default3600)Context
The gateway's K8s SA authenticator validates sandbox tokens via TokenReview with audience
openshell-gateway. PR #6 added the env var but pointed it at the default K8s SA tokenwhich carries the wrong audience (
https://kubernetes.default.svc.cluster.local), causing:This PR adds the projected volume with the correct audience, matching the upstream in-tree
driver implementation (
kagenti/OpenShell@mvp-v2:crates/openshell-driver-kubernetes/src/driver.rs).Fixes: kagenti/kagenti#1815
Test plan
go test ./...)Assisted-By: Claude Code