feat: inject projected SA token volume into sandbox pods#7
Merged
Conversation
The gateway's K8s SA authenticator requires tokens with audience "openshell-gateway". Add a projected serviceAccountToken volume to sandbox pods and set OPENSHELL_K8S_SA_TOKEN_FILE so the supervisor can authenticate back to the gateway via IssueSandboxToken. New CLI flags: -sa-token-audience (default: "openshell-gateway") -sa-token-ttl-secs (default: 3600) Fixes: kagenti/kagenti#1815 Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serviceAccountTokenvolume with audienceopenshell-gatewayto sandbox pods/var/run/secrets/openshell/token(read-only, mode 0400)OPENSHELL_K8S_SA_TOKEN_FILEenv var so the supervisor finds the token-sa-token-audience(defaultopenshell-gateway),-sa-token-ttl-secs(default3600)Context
The mvp-v2 gateway validates sandbox SA tokens via K8s TokenReview with audience
openshell-gateway. The default K8s SA token carries the wrong audience(
https://kubernetes.default.svc.cluster.local), causing authentication failure.This matches the upstream in-tree driver implementation at
kagenti/OpenShell@mvp-v2:crates/openshell-driver-kubernetes/src/driver.rs.Fixes: kagenti/kagenti#1815
Test plan
go test ./...)Assisted-By: Claude Code