fix: use copy-self for supervisor init container (scratch image compat)#5
Merged
Conversation
The mvp-v2 supervisor image switched from Ubuntu to scratch — it only contains the static openshell-sandbox binary at /openshell-sandbox. The previous init container used sh -c "cp ..." which fails because there's no shell in the image. Switch to the supervisor binary's built-in copy-self subcommand, which the upstream Rust K8s driver already uses. Also remove the dtach binary config (not present in mvp-v2 images). Fixes: kagenti/kagenti#1815 Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sh -c "cp ..."to the supervisor binary's built-incopy-selfsubcommandDtachBinaryPathconfig and--dtach-binary-pathCLI flagSupervisorBinaryPathdefault from/usr/local/bin/openshell-sandboxto/openshell-sandbox(scratch image layout)The mvp-v2 supervisor image is
FROM scratch— it contains only the static binary at/openshell-sandbox. The previoussh -c "cp ..."approach fails because there's no shell in the image. Thecopy-selfsubcommand is what the upstream Rust K8s driver already uses.Fixes: kagenti/kagenti#1815
Test plan
Assisted-By: Claude Code