feat(helm/kmcp): support deployment annotations#136
Open
anthonyhaussman wants to merge 1 commit into
Open
Conversation
Add global annotations and controller.annotations keys, mirroring the sibling kagent chart (PR #2143). The Deployment metadata.annotations block uses mergeOverwrite so controller-specific annotations override global ones on key collisions. kmcp has a single Deployment (controller-manager), so no ui.annotations equivalent is needed. Tests cover global-only and override-on-collision cases. helm lint clean, unittest 50/50 pass. Assisted-by: GLM 5.2 Signed-off-by: Anthony Hausman <anthonyhausman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add global annotations and
controller.annotationskeys, mirroring the sibling kagent chart (PR #2143).The Deployment
metadata.annotationsblock uses mergeOverwrite so controller-specific annotations override global ones on key collisions. kmcp has a single Deployment (controller-manager), so noui.annotationsequivalent is needed.