fix: align sourceFileVersions parsing with maxEmbeddedVersion#2194
Open
mesutoezdil wants to merge 1 commit into
Open
fix: align sourceFileVersions parsing with maxEmbeddedVersion#2194mesutoezdil wants to merge 1 commit into
mesutoezdil wants to merge 1 commit into
Conversation
github-actions
Bot
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns the CLI migration filename version parsing (sourceFileVersions) with the runtime embedded-migrations parsing (maxEmbeddedVersion) by accepting any .up.sql file whose filename begins with decimal digits, rather than requiring an underscore separator.
Changes:
- Updated
sourceFileVersionsto parse versions usingfmt.Sscanf(name, "%d", &v)to matchmaxEmbeddedVersionbehavior. - Broadens recognized migration filenames from
NNN_name.up.sqlto any.up.sqlfilename with a leading integer.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mesutoezdil
force-pushed
the
fix/migrate-source-file-versions-parsing
branch
from
1ccb40d to
083df7e
Compare
Contributor
Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
mesutoezdil
force-pushed
the
fix/migrate-source-file-versions-parsing
branch
from
7a0c6d8 to
e745a8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sourceFileVersions used strings.SplitN and skipped files without underscore, but maxEmbeddedVersion in runner.go uses fmt.Sscanf on any leading integer. this patch makes both consistent.