feat: add claude ACP sandbox target#2189
Merged
EItanya merged 7 commits intoJul 10, 2026
Merged
Conversation
Signed-off-by: Avri Chen-Roth <avri210984@gmail.com>
Signed-off-by: Avri Chen-Roth <avri210984@gmail.com>
The initialize handshake round-trips against the built image (protocolVersion 1, authMethods empty → env-key auth, no separate authenticate step). Narrows the open item to the full prompt round-trip and reconnect behavior. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Avri Chen-Roth <avri210984@gmail.com>
Add the claude target to the CI build matrix (ci.yaml) and the release push matrix (tag.yaml), plus the supporting Makefile pieces: build-acp-sandbox-claude target, image-name/IMG vars, print-images echo, and the build-acp-sandbox aggregate dependency. Scope is the standalone image only — not wired into build-controller or the digest-embedding (that is harness-backend integration, tracked separately). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Avri Chen-Roth <avri210984@gmail.com>
the-mentor
force-pushed
the
feat/claude-acp-sandbox-target
branch
from
008cfa3 to
aa67df4
Compare
- Add missing "from another shell" instruction to the claude smoke-test block (consistent with the hermes example above it) - Add note that a successful initialize handshake does not confirm end-to-end prompt processing - Clarify table entry: claude-agent-acp speaks to the shim over stdio; the shim still exposes ws://0.0.0.0:9000/acp externally Signed-off-by: Avri Chen-Roth <avri210984@gmail.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
enhancement
3 tasks
Contributor
|
+1 would love to see this |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new ACP sandbox image target for Anthropic Claude by introducing a claude Docker build stage that runs claude-agent-acp under the existing acp-shim entrypoint, and wires the new image into local builds and CI/tag workflows.
Changes:
- Added
claudetarget todocker/acp-sandbox/Dockerfilethat installs@agentclientprotocol/claude-agent-acp@0.58.1and runs it as the shim child process. - Updated
Makefileto build/pushacp-sandbox-claudeand include it in thebuild-acp-sandboxaggregate target and image-version output. - Updated CI/tag workflows and
docker/acp-sandbox/README.mdto include the new image target and usage notes.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Makefile | Adds image vars + build-acp-sandbox-claude target and includes it in aggregate build targets/output. |
| docker/acp-sandbox/README.md | Documents the new claude target and runtime requirements (ANTHROPIC_API_KEY) plus smoke-test steps. |
| docker/acp-sandbox/Dockerfile | Introduces claude stage built on node-base that runs claude-agent-acp via the shim. |
| .github/workflows/tag.yaml | Adds acp-sandbox-claude to the release build matrix. |
| .github/workflows/ci.yaml | Adds acp-sandbox-claude to the CI build matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Avri Chen-Roth <the-mentor@users.noreply.github.com>
EItanya
approved these changes
Jul 10, 2026
Contributor
|
Thanks so much for the contribution, are you planning on adding support for using this in as well? |
Contributor
Author
|
@EItanya yes I'm planning on working on it next. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claudetarget todocker/acp-sandbox/Dockerfileusing@agentclientprotocol/claude-agent-acp@0.58.1(wraps@anthropic-ai/claude-agent-sdk) on top of thenode-basestage (Node ≥22 required)openclawtarget, no sandbox-local gateway is needed —claude-agent-acpspeaks ACP over stdio directly, so the shim runs it as its child:CMD ["--", "claude-agent-acp"]build-acp-sandbox-claudeinto the Makefile and addsacp-sandbox-claudeto the build matrix in bothci.yamlandtag.yamldocker/acp-sandbox/README.mdACP handshake status
Verified locally at v0.58.1:
initializereturnsprotocolVersion: 1,agentInfo.version: "0.58.1",authMethods: []. Authentication is viaANTHROPIC_API_KEYinjected at runtime — no separateauthenticatestep.Still to verify: full
session/promptround-trip reaches the model, and the in-memory session model holds across bridge reconnects.Test plan
acp-sandbox-claudeimage successfullydocker run --rm -p 9000:9000 -e ANTHROPIC_API_KEY=<key> kagent/acp-sandbox-claude+websocat -1 ws://localhost:9000/acp→initializesucceedsmake build-acp-sandbox-claudeworks locallymake build-acp-sandboxnow includes the claude target🤖 Generated with Claude Code