Remove cr.kagent.dev alias usage#2177
Conversation
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
There was a problem hiding this comment.
Pull request overview
This PR removes usage of the cr.kagent.dev registry alias across the project by switching default image registries and test expectations to ghcr.io, and by updating the CLI install script to download release assets directly from GitHub Releases.
Changes:
- Update CLI installer to fetch binaries/checksums from GitHub Releases.
- Switch Helm chart default registry (and Helm unit tests) from
cr.kagent.devtoghcr.io. - Update Go defaults/tests and translator golden outputs to expect
ghcr.ioimage references.
Reviewed changes
Copilot reviewed 44 out of 44 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/get-kagent | Switch installer download base URL from cr.kagent.dev to GitHub Releases. |
| helm/kagent/values.yaml | Change default image registry value to ghcr.io. |
| helm/kagent/tests/ui-deployment_test.yaml | Update Helm unit test expectations from cr.kagent.dev to ghcr.io for UI image. |
| helm/kagent/tests/controller-deployment_test.yaml | Update Helm unit test expectations from cr.kagent.dev to ghcr.io for controller image. |
| go/core/pkg/sandboxbackend/substrate/constants.go | Remove cr.kagent.dev mention from substrate sandbox image comment. |
| go/core/pkg/sandboxbackend/substrate/constants_test.go | Update substrate sandbox image resolution tests to expect ghcr.io. |
| go/core/internal/controller/translator/agent/adk_api_translator.go | Update default image registry config(s) to ghcr.io. |
| go/core/internal/controller/translator/agent/imageconfig_test.go | Update image config tests to expect ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/tls-with-system-cas-disabled.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/tls-with-disabled-verify.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/tls-with-custom-ca.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/ollama_agent.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/bedrock_agent.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/basic_agent.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/anthropic_agent.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_system_message_from_secret.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_system_message_from_configmap.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_streaming.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_skills.json | Update golden output image registry to ghcr.io (including skills-init initContainer image). |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_security_context.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_scheduling_attributes.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_require_approval.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_proxy.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_proxy_service.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_proxy_mcpserver.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_proxy_mcpserver_custom_timeout.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_proxy_external_remotemcp.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_prompt_template.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_passthrough.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_nested_agent.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_memory.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_mcp_service.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_http_toolserver.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_git_skills.json | Update golden output image registry to ghcr.io (including skills-init initContainer image). |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_extra_containers.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_embedding_provider.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_default_sa.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_custom_sa.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_cross_namespace_tools.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_context_config.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_code.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_allowed_headers.json | Update golden output image registry to ghcr.io. |
| go/core/internal/controller/translator/agent/testdata/outputs/agent_with_a2a_config.json | Update golden output image registry to ghcr.io. |
| contrib/cncf/technical-review.md | Update release artifact documentation to point container images at ghcr.io. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| KAGENT_DIST="kagent-$OS-$ARCH" | ||
| DOWNLOAD_URL="https://cr.kagent.dev/$TAG/$KAGENT_DIST" | ||
| DOWNLOAD_URL="https://github.com/kagent-dev/kagent/releases/download/$TAG/$KAGENT_DIST" | ||
| CHECKSUM_URL="$DOWNLOAD_URL.sha256" |
There was a problem hiding this comment.
That wouldn't have worked before though...
| KAGENT_DIST="kagent-$OS-$ARCH" | ||
| DOWNLOAD_URL="https://cr.kagent.dev/$TAG/$KAGENT_DIST" | ||
| DOWNLOAD_URL="https://github.com/kagent-dev/kagent/releases/download/$TAG/$KAGENT_DIST" | ||
| CHECKSUM_URL="$DOWNLOAD_URL.sha256" | ||
| KAGENT_TMP_ROOT="$(mktemp -dt kagent-installer-XXXXXX)" | ||
| KAGENT_TMP_FILE="$KAGENT_TMP_ROOT/$KAGENT_DIST" |
Getting this today... installing 0.9.9... |
I'm really sorry @marcellodesales, that's exactly why we're trying to move away, for now you can just use |
Summary
Testing
Note: full helm unittest helm/kagent still fails on the existing agent-nodeselector_test.yaml suite unrelated to this change.