Skip to content

Remove cr.kagent.dev alias usage#2177

Open
EItanya wants to merge 2 commits into
mainfrom
remove-cr-kagent-dev-alias
Open

Remove cr.kagent.dev alias usage#2177
EItanya wants to merge 2 commits into
mainfrom
remove-cr-kagent-dev-alias

Conversation

@EItanya

@EItanya EItanya commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replace cr.kagent.dev image defaults and test expectations with ghcr.io
  • download CLI install assets from GitHub releases instead of the cr.kagent.dev alias
  • update release docs and generated translator golden outputs

Testing

  • go test ./core/internal/controller/translator/agent ./core/pkg/sandboxbackend/substrate
  • helm unittest -f 'tests/deployment' helm/kagent
  • git diff --check

Note: full helm unittest helm/kagent still fails on the existing agent-nodeselector_test.yaml suite unrelated to this change.

Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
@EItanya EItanya requested a review from a team as a code owner July 7, 2026 20:46
Copilot AI review requested due to automatic review settings July 7, 2026 20:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes usage of the cr.kagent.dev registry alias across the project by switching default image registries and test expectations to ghcr.io, and by updating the CLI install script to download release assets directly from GitHub Releases.

Changes:

  • Update CLI installer to fetch binaries/checksums from GitHub Releases.
  • Switch Helm chart default registry (and Helm unit tests) from cr.kagent.dev to ghcr.io.
  • Update Go defaults/tests and translator golden outputs to expect ghcr.io image references.

Reviewed changes

Copilot reviewed 44 out of 44 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
scripts/get-kagent Switch installer download base URL from cr.kagent.dev to GitHub Releases.
helm/kagent/values.yaml Change default image registry value to ghcr.io.
helm/kagent/tests/ui-deployment_test.yaml Update Helm unit test expectations from cr.kagent.dev to ghcr.io for UI image.
helm/kagent/tests/controller-deployment_test.yaml Update Helm unit test expectations from cr.kagent.dev to ghcr.io for controller image.
go/core/pkg/sandboxbackend/substrate/constants.go Remove cr.kagent.dev mention from substrate sandbox image comment.
go/core/pkg/sandboxbackend/substrate/constants_test.go Update substrate sandbox image resolution tests to expect ghcr.io.
go/core/internal/controller/translator/agent/adk_api_translator.go Update default image registry config(s) to ghcr.io.
go/core/internal/controller/translator/agent/imageconfig_test.go Update image config tests to expect ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/tls-with-system-cas-disabled.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/tls-with-disabled-verify.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/tls-with-custom-ca.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/ollama_agent.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/bedrock_agent.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/basic_agent.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/anthropic_agent.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_system_message_from_secret.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_system_message_from_configmap.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_streaming.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_skills.json Update golden output image registry to ghcr.io (including skills-init initContainer image).
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_security_context.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_scheduling_attributes.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_require_approval.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_proxy.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_proxy_service.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_proxy_mcpserver.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_proxy_mcpserver_custom_timeout.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_proxy_external_remotemcp.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_prompt_template.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_passthrough.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_nested_agent.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_memory.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_mcp_service.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_http_toolserver.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_git_skills.json Update golden output image registry to ghcr.io (including skills-init initContainer image).
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_extra_containers.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_embedding_provider.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_default_sa.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_custom_sa.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_cross_namespace_tools.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_context_config.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_code.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_allowed_headers.json Update golden output image registry to ghcr.io.
go/core/internal/controller/translator/agent/testdata/outputs/agent_with_a2a_config.json Update golden output image registry to ghcr.io.
contrib/cncf/technical-review.md Update release artifact documentation to point container images at ghcr.io.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread scripts/get-kagent
Comment on lines 145 to 147
KAGENT_DIST="kagent-$OS-$ARCH"
DOWNLOAD_URL="https://cr.kagent.dev/$TAG/$KAGENT_DIST"
DOWNLOAD_URL="https://github.com/kagent-dev/kagent/releases/download/$TAG/$KAGENT_DIST"
CHECKSUM_URL="$DOWNLOAD_URL.sha256"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That wouldn't have worked before though...

Comment thread scripts/get-kagent
Comment on lines 145 to 149
KAGENT_DIST="kagent-$OS-$ARCH"
DOWNLOAD_URL="https://cr.kagent.dev/$TAG/$KAGENT_DIST"
DOWNLOAD_URL="https://github.com/kagent-dev/kagent/releases/download/$TAG/$KAGENT_DIST"
CHECKSUM_URL="$DOWNLOAD_URL.sha256"
KAGENT_TMP_ROOT="$(mktemp -dt kagent-installer-XXXXXX)"
KAGENT_TMP_FILE="$KAGENT_TMP_ROOT/$KAGENT_DIST"
@marcellodesales

Copy link
Copy Markdown
⏺ Bash(kubectl get pods -n kagent 2>&1 | head; echo "=== querydoc containers ==="; kubectl get pod -n kagent -l app=querydoc -o jsonpath='{range .items[0].status.conta…)
  ⎿  Error: Exit code 1
     NAME                                              READY   STATUS             RESTARTS   AGE
     kagent-controller-77d5895896-nqvks                1/2     ImagePullBackOff   0          2m59s
     kagent-grafana-mcp-866ccb5bc7-jjspx               2/2     Running            0          2m59s
     kagent-kmcp-controller-manager-6d8b8d65bd-2wvnd   2/2     Running            0          2m58s
     kagent-postgresql-74b6758c79-kx88r                2/2     Running            0          2m58s
     kagent-querydoc-7fdbf64689-89mq6                  2/2     Running            0          2m58s
     kagent-tools-554dcd79cc-jv2vz                     2/2     Running            0          2m58s
     kagent-ui-77fc885698-hjztv                        1/2     ImagePullBackOff   0          2m58s
     === querydoc containers ===
     … +5 lines (ctrl+o to expand)

Getting this today... installing 0.9.9...

@EItanya

EItanya commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author
⏺ Bash(kubectl get pods -n kagent 2>&1 | head; echo "=== querydoc containers ==="; kubectl get pod -n kagent -l app=querydoc -o jsonpath='{range .items[0].status.conta…)
  ⎿  Error: Exit code 1
     NAME                                              READY   STATUS             RESTARTS   AGE
     kagent-controller-77d5895896-nqvks                1/2     ImagePullBackOff   0          2m59s
     kagent-grafana-mcp-866ccb5bc7-jjspx               2/2     Running            0          2m59s
     kagent-kmcp-controller-manager-6d8b8d65bd-2wvnd   2/2     Running            0          2m58s
     kagent-postgresql-74b6758c79-kx88r                2/2     Running            0          2m58s
     kagent-querydoc-7fdbf64689-89mq6                  2/2     Running            0          2m58s
     kagent-tools-554dcd79cc-jv2vz                     2/2     Running            0          2m58s
     kagent-ui-77fc885698-hjztv                        1/2     ImagePullBackOff   0          2m58s
     === querydoc containers ===
     … +5 lines (ctrl+o to expand)

Getting this today... installing 0.9.9...

I'm really sorry @marcellodesales, that's exactly why we're trying to move away, for now you can just use ghcr.io to get around it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants