Skip to content

feat(helm): add UI HTTPRoute#2165

Open
younsl wants to merge 3 commits into
kagent-dev:mainfrom
younsl:feat/helm-httproute-extraobjects
Open

feat(helm): add UI HTTPRoute#2165
younsl wants to merge 3 commits into
kagent-dev:mainfrom
younsl:feat/helm-httproute-extraobjects

Conversation

@younsl

@younsl younsl commented Jul 6, 2026

Copy link
Copy Markdown

Summary

Adds an optional Gateway API HTTPRoute for the UI. It is off by default so existing installs are unaffected.

  • ui.httpRoute: lets users front the UI with a Gateway API implementation such as kgateway or Istio or Envoy Gateway instead of the OpenShift Route or the bundled oauth2-proxy.

Changes

HTTPRoute (ui.httpRoute)

  • New template templates/ui-httproute.yaml gated behind ui.httpRoute.enabled (default false).
  • Supports parentRefs and hostnames and per-rule matches / filters / timeouts.
  • When a rule omits backendRefs it defaults to the UI Service on ui.service.ports.port.
{{- if .Values.ui.httpRoute.enabled }}
apiVersion: gateway.networking.k8s.io/v1
kind: HTTPRoute
...
{{- end }}

Testing

Added helm-unittest suite tests/ui-httproute_test.yaml.

helm unittest helm/kagent

References

Notes

  • No change to existing rendered output when ui.httpRoute.enabled stays at its default.

Adds an optional Gateway API HTTPRoute for the kagent UI, gated behind
ui.httpRoute.enabled (default false). This lets users front the UI with a
Gateway API implementation (kgateway, Istio, Envoy Gateway, etc.) instead
of the OpenShift Route or the bundled oauth2-proxy.

Supports parentRefs, hostnames, and per-rule matches/filters/timeouts. When
a rule omits backendRefs it defaults to the UI Service on
ui.service.ports.port. Covered by helm-unittest cases.

Signed-off-by: younsl <cysl@kakao.com>
Copilot AI review requested due to automatic review settings July 6, 2026 09:33
@github-actions github-actions Bot added the enhancement New feature or request label Jul 6, 2026
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the helm/kagent chart with two opt-in features: (1) a Gateway API HTTPRoute for exposing the UI via a Gateway implementation, and (2) extraObjects, a tpl-rendered list for shipping arbitrary additional manifests with the release.

Changes:

  • Adds ui.httpRoute values and a new templates/ui-httproute.yaml to render an optional UI HTTPRoute.
  • Adds extraObjects values and a new templates/extra-objects.yaml to render arbitrary, tpl-expanded manifests.
  • Adds helm-unittest coverage for both new templates.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
helm/kagent/values.yaml Adds configuration for ui.httpRoute and top-level extraObjects.
helm/kagent/templates/ui-httproute.yaml New optional Gateway API HTTPRoute template for the UI.
helm/kagent/templates/extra-objects.yaml New template to render user-provided extraObjects via tpl.
helm/kagent/tests/ui-httproute_test.yaml Unit tests validating HTTPRoute rendering behavior.
helm/kagent/tests/extra-objects_test.yaml Unit tests validating extraObjects rendering behavior (map + string).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread helm/kagent/templates/ui-httproute.yaml
Comment thread helm/kagent/values.yaml
Comment thread helm/kagent/templates/extra-objects.yaml Outdated
@younsl younsl force-pushed the feat/helm-httproute-extraobjects branch from 6e1f021 to aec643c Compare July 6, 2026 09:42

@EItanya EItanya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there, I think there are a mixture of concerns here that I'd like to tease apart.

  1. The HTTPRoute seems generally useful and I'd like to discuss the pros/cons
  2. The arbitrary extra objects is unrelated and should be split up into a separate PR to debate on its own merit

@younsl younsl force-pushed the feat/helm-httproute-extraobjects branch from aec643c to cfbb887 Compare July 7, 2026 04:56
@younsl

younsl commented Jul 7, 2026

Copy link
Copy Markdown
Author

Thanks for the review. Agreed on splitting these up. This PR now only contains the HTTPRoute change. I dropped the extraObjects commit and will open a separate PR for it so it can be debated on its own merit. Happy to discuss the pros and cons of the HTTPRoute here.

@younsl younsl requested a review from EItanya July 7, 2026 04:57
@younsl younsl requested a review from a team as a code owner July 7, 2026 14:03
@younsl younsl changed the title feat(helm): add UI HTTPRoute and tpl-rendered extraObjects feat(helm): add UI HTTPRoute Jul 7, 2026
@github-actions github-actions Bot added enhancement New feature or request and removed enhancement New feature or request labels Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants