Skip to content

chore: upgrade google.golang.org/adk to v2.0.0#2152

Open
yanivmn wants to merge 2 commits into
kagent-dev:mainfrom
yanivmn:chore/upgrade-go-adk-v2
Open

chore: upgrade google.golang.org/adk to v2.0.0#2152
yanivmn wants to merge 2 commits into
kagent-dev:mainfrom
yanivmn:chore/upgrade-go-adk-v2

Conversation

@yanivmn

@yanivmn yanivmn commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

No description provided.

yanivmar and others added 2 commits July 5, 2026 14:46
Bump the Go ADK dependency from v1.4.0 to v2.0.0. The major version
requires the /v2 module path suffix, so all imports were rewritten
accordingly.

Adapts to the v2 breaking change that unified agent.ToolContext and
agent.CallbackContext into a single agent.Context, and adds the new
InvocationContext methods (IsolationScope, ResumedInput, WithICDelta)
to the sts test fake.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Yaniv Marom Nachumi <yanivmar@amdocs.com>
Add a provisional enhancement proposal to expose the Google ADK workflow
agent types through the declarative Agent CRD. Today every declarative
agent compiles to a single LlmAgent; this EP proposes a `kind`
discriminator plus sub-agent references so users can build deterministic
Sequential, Parallel, and Loop workflows natively.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Yaniv Marom Nachumi <yanivmar@amdocs.com>
Copilot AI review requested due to automatic review settings July 5, 2026 12:39
@github-actions github-actions Bot added ignore-for-release enhancement-proposal Indicates that this PR is for an enhancement proposal labels Jul 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Upgrades the Go runtime integration with Google ADK from google.golang.org/adk v1.4.0 to google.golang.org/adk/v2 v2.0.0, updating imports and callback/context types across kagent’s ADK-facing packages.

Changes:

  • Bump dependency from google.golang.org/adk to google.golang.org/adk/v2 (go.mod/go.sum).
  • Update Go code to new v2 import paths and context/callback signatures (e.g., ToolContextContext in tool handlers/callbacks).
  • Add a design EP draft describing future support for ADK workflow agent types.

Reviewed changes

Copilot reviewed 37 out of 38 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
go/go.mod Switch dependency to google.golang.org/adk/v2 v2.0.0.
go/go.sum Update module sums for ADK v2.
go/adk/pkg/tools/skills.go Migrate ADK imports and tool handler context type to v2.
go/adk/pkg/tools/share_tools.go Migrate ADK imports and handler context type to v2.
go/adk/pkg/tools/remote_a2a_tool.go Migrate ADK imports and tool handler context type to v2.
go/adk/pkg/tools/ask_user.go Migrate ADK imports and tool handler context type to v2.
go/adk/pkg/telemetry/tracing.go Update ADK telemetry import to v2.
go/adk/pkg/telemetry/attributes.go Update ADK model import to v2.
go/adk/pkg/telemetry/attributes_test.go Update ADK model import to v2 in tests.
go/adk/pkg/sts/plugin.go Update ADK agent/plugin imports to v2.
go/adk/pkg/sts/plugin_test.go Update ADK imports and fake InvocationContext to satisfy v2 interfaces.
go/adk/pkg/session/session.go Update ADK session import to v2.
go/adk/pkg/session/session_test.go Update ADK session import to v2 in tests.
go/adk/pkg/session/local_session.go Update ADK session import to v2.
go/adk/pkg/runner/adapter.go Update ADK runner/session/tool/memory/plugin imports to v2.
go/adk/pkg/models/sapaicore_adk.go Update ADK model import to v2.
go/adk/pkg/models/sapaicore_adk_test.go Update ADK model import to v2 in tests.
go/adk/pkg/models/openai_adk.go Update ADK model import to v2.
go/adk/pkg/models/ollama_adk.go Update ADK model import to v2.
go/adk/pkg/models/bedrock.go Update ADK model import to v2.
go/adk/pkg/models/anthropic_adk.go Update ADK model import to v2.
go/adk/pkg/memory/save_memory_tool.go Update ADK imports and tool handler context type to v2.
go/adk/pkg/memory/kagent_service.go Update ADK memory/model/session imports to v2.
go/adk/pkg/memory/kagent_service_test.go Update ADK memory/session imports to v2 in tests.
go/adk/pkg/mcp/registry.go Update ADK tool/mcptoolset imports to v2.
go/adk/pkg/app/app.go Update ADK agent import to v2.
go/adk/pkg/agent/createllm_test.go Update ADK imports to v2 in tests.
go/adk/pkg/agent/approval.go Update ADK imports and callback context type to v2.
go/adk/pkg/agent/agent.go Update ADK imports and tool callback context types to v2.
go/adk/pkg/a2a/hitl.go Update ADK toolconfirmation import to v2.
go/adk/pkg/a2a/executor.go Update ADK agent/runner/server imports to v2.
go/adk/pkg/a2a/converter.go Update ADK server/session imports to v2.
go/adk/pkg/a2a/converter_test.go Update ADK server import to v2 in tests.
go/adk/pkg/a2a/consts.go Update ADK server import to v2.
go/adk/pkg/a2a/agentcard.go Update ADK agent/server imports to v2.
go/adk/examples/oneshot/main.go Update ADK imports to v2 in example.
go/adk/examples/byo/main.go Update ADK imports to v2 in example.
design/EP-XXXX-adk-agent-types.md Add design EP draft tied to ADK v2 workflow agent types.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +1 to +4
# EP-XXXX: Support for ADK workflow agent types (Sequential, Parallel, Loop)

* Issue: [#XXXX](https://github.com/kagent-dev/kagent/issues/XXXX)
* Status: `provisional`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this design doc relevant to this PR?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two commits to this PR.

  1. Package version upgrade and adoption
  2. design to support additional agent types for ADK workflows

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we separate them? I'm happy to merge the bump, but would like time to look through the design

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement-proposal Indicates that this PR is for an enhancement proposal ignore-for-release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants