chore(deps): Update controller-runtime from v0.23.3 to v0.24.0 and k8s dependencie to support k8s 1.36#1804
Open
dongjiang1989 wants to merge 1 commit intokagent-dev:mainfrom
Open
Conversation
…s to support k8s 1.26 Signed-off-by: dongjiang <dongjiang1989@126.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades Kubernetes/controller-runtime Go dependencies and updates the API scaffolding to remove usage of the deprecated sigs.k8s.io/controller-runtime/pkg/scheme.Builder, aligning the API packages with the upstream Kubernetes runtime.SchemeBuilder pattern. It also regenerates CRD manifests/templates to reflect the updated dependency schema metadata.
Changes:
- Bump
sigs.k8s.io/controller-runtimetov0.24.0and updatek8s.io/*module versions accordingly (plus related dependency refresh ingo.sum). - Replace deprecated controller-runtime
scheme.Builderusage withk8s.io/apimachinery/pkg/runtime.NewSchemeBuilderand update type registration toAddKnownTypes(...). - Regenerate CRD YAMLs (both
go/api/config/crd/basesand Helm CRD templates), updating description text based on the newer schema source.
Reviewed changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| helm/kagent-crds/templates/kagent.dev_sandboxagents.yaml | Regenerated Helm CRD template; description text updated to match newer schema. |
| helm/kagent-crds/templates/kagent.dev_agents.yaml | Regenerated Helm CRD template; description text updated to match newer schema. |
| go/go.mod | Bumps controller-runtime and k8s module versions; adds direct apiextensions-apiserver requirement; updates x/exp + other deps. |
| go/go.sum | Refreshes dependency checksums to match go.mod updates (ginkgo/gomega, otelgrpc, k8s libs, etc.). |
| go/api/v1alpha2/zz_generated.deepcopy.go | Gofmt-style import cleanup (remove redundant import alias). |
| go/api/v1alpha2/sandboxagent_types.go | Switch type registration to runtime.SchemeBuilder function-based registration. |
| go/api/v1alpha2/remotemcpserver_types.go | Switch type registration to runtime.SchemeBuilder function-based registration. |
| go/api/v1alpha2/modelproviderconfig_types.go | Switch type registration to runtime.SchemeBuilder function-based registration. |
| go/api/v1alpha2/modelconfig_types.go | Switch type registration to runtime.SchemeBuilder function-based registration. |
| go/api/v1alpha2/groupversion_info.go | Replace controller-runtime scheme builder with runtime.NewSchemeBuilder + metav1.AddToGroupVersion. |
| go/api/v1alpha2/agent_types.go | Switch type registration to runtime.SchemeBuilder function-based registration. |
| go/api/v1alpha1/zz_generated.deepcopy.go | Gofmt-style import cleanup (remove redundant import alias). |
| go/api/v1alpha1/toolserver_types.go | Switch type registration to runtime.SchemeBuilder function-based registration. |
| go/api/v1alpha1/modelconfig_types.go | Switch type registration to runtime.SchemeBuilder function-based registration. |
| go/api/v1alpha1/memory_types.go | Switch type registration to runtime.SchemeBuilder function-based registration. |
| go/api/v1alpha1/groupversion_info.go | Replace controller-runtime scheme builder with runtime.NewSchemeBuilder + metav1.AddToGroupVersion. |
| go/api/v1alpha1/agent_types.go | Switch type registration to runtime.SchemeBuilder function-based registration. |
| go/api/config/crd/bases/kagent.dev_sandboxagents.yaml | Regenerated CRD base manifest; description text updated to match newer schema. |
| go/api/config/crd/bases/kagent.dev_agents.yaml | Regenerated CRD base manifest; description text updated to match newer schema. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
cc @EItanya PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Upgrade controller-runtime from v0.23.3 to v0.24.0 and k8s dependencies to support k8s 1.26
Changes required:
scheme.Builder:Solution
Replace deprecated sigs.k8s.io/controller-runtime/pkg/scheme.Builder with
k8s.io/apimachinery/pkg/runtime.NewSchemeBuilder() in scaffolding templates.
Before:
After:
This reduces API package dependencies and follows Kubernetes core API patterns.