feat: support custom service account override in agent crds #1254
+723
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io>
supreme-gg-gg
requested review from
EItanya,
ilackarms and
yuval-k
as code owners
Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io>
Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io>
EItanya
requested changes
Jan 30, 2026
Contributor
EItanya
left a comment
EItanya
left a comment
There was a problem hiding this comment.
One main comment, also can you add a golden test
Comment on lines
176
to
179
| // +optional | ||
| ServiceAccountName *string `json:"serviceAccountName,omitempty"` | ||
| // +optional | ||
| ServiceAccountConfig *ServiceAccountConfig `json:"serviceAccountConfig,omitempty"` |
Contributor
There was a problem hiding this comment.
Can you add a cel rule to ensure that only one of these can be set. If the ServiceAccountName is set, than we won't create the ServiceAccount. And if the config is set, then the name can't be changed.
Also can you add more comments to these fields to explain a bit about this interaction
Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io>
Signed-off-by: Jet Chiang <pokyuen.jetchiang-ext@solo.io>
EItanya
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
serviceAccountNameto use existing SA instead of creating a new SA for each agent pod. If not provided, will default to agent name and create a new SA. Alternatively, provideserviceAccountConfigthat will be applied to every SA created by the agent controller. Close #1233