refactor: use paper's new configuration phase events#385
Open
amyavi wants to merge 1 commit intokaboomserver:masterfrom
Open
refactor: use paper's new configuration phase events#385amyavi wants to merge 1 commit intokaboomserver:masterfrom
amyavi wants to merge 1 commit intokaboomserver:masterfrom
Conversation
amyavi
force-pushed
the
refactor/use-configuration-events
branch
from
73e98c2 to
4de49b1
Compare
amyavi
force-pushed
the
refactor/use-configuration-events
branch
from
4de49b1 to
795fbf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm hoping Paper makes this API better in the future - the lack of a getProfile method on the PlayerConnection interface is... strange, to say the least.
This will do for now, though.