Skip to content

fix: wait for process terminaison to avoid zombies #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdevolde merged 1 commit into from
Dec 29, 2025
Merged

fix: wait for process terminaison to avoid zombies #147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions language_tool_python/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,12 @@ def _kill_processes(processes: List[subprocess.Popen[str]]) -> None:
:param processes: A list of subprocess.Popen objects representing the running server processes.
:type processes: List[subprocess.Popen]
"""
for pid in [p.pid for p in processes]:
for p in processes:
with contextlib.suppress(psutil.NoSuchProcess):
kill_process_force(pid=pid)
kill_process_force(pid=p.pid)
# Wait to avoid zombies
with contextlib.suppress(subprocess.TimeoutExpired):
p.wait(timeout=5)


class LanguageTool:
Expand Down