chore(ci): build multiarch in github actions#230
chore(ci): build multiarch in github actions#230jeboehm wants to merge 1 commit intojwilder:masterfrom
Conversation
|
@jeboehm I don't understand why we need docker images? Do you want to get binary from docker images when build your images? This is library so docker image might be not that much useful. For multi arch image you can use https://github.com/jwilder/dockerize/releases/tag/v0.9.9 like we are doing here - https://github.com/Improwised/docker-php-base/blob/master/Dockerfile#L6 |
|
Could you please elaborate on what your example has to do with multi arch? The project already provides Docker images. They're incompatible with ARM. This PR solves that. |
|
@jeboehm In my example, image that we are building it is multi-arch image. Might be in your case you are using dockerize image directly. |
In line 6 you are downloading the amd64 variant. |
|
@jeboehm Apologies, I pasted the wrong link. Here is correct link - https://github.com/Improwised/docker-php-base/blob/8.4-s6/Dockerfile#L15 |
|
Thank you. You add a layer of complexity that is already solved in the underlying technology: Docker. With multi-arch images you just do
and you're done. |
|
Yes. That will be nice |
Hi
I deploy Dockerize by using multistage Docker builds and copying the binary from your provided Docker image very often.
Yet there are no arm64 images available although ARM on Mac and ARM-Servers are more and more common.
This pull request adds a a workflow to build and push images to the ghcr.io repository for both architectures. Additionally, the images will be signed with the commit hash to provide a little extra layer of security (I think).
It was not possible for me to find out how you push images to the docker.io repository at the moment. I'd suggest to extend the workflow to do that: https://docs.docker.com/build/ci/github-actions/push-multi-registries/