feat: module to display current screen session#286
Open
andrzejnovak wants to merge 1 commit intojustjanne:mainfrom
Open
feat: module to display current screen session#286andrzejnovak wants to merge 1 commit intojustjanne:mainfrom
andrzejnovak wants to merge 1 commit intojustjanne:mainfrom
Conversation
betaboon
reviewed
Aug 17, 2021
| } | ||
| // envName := env | ||
| envName := strings.Split(env, ".")[1] | ||
| if p.cfg.VenvNameSizeLimit > 0 && len(envName) > p.cfg.VenvNameSizeLimit { |
Contributor
There was a problem hiding this comment.
seems like a bad idea to reuse settings from the Venv-segment. ;)
Contributor
|
@andrzejnovak do you want to pick this PR up again or would you prefer someone else doing that ? |
Author
|
I don't see myself having time to update it anytime soon. No problem if someone else picks it up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #283
Thanks a lot for this package btw, it's great!