fix(tui/new): preserve resumed sessions #491
Conversation
Clear experimental_resume for /new, flush snapshot + shutdown old session, and insert MCP notice via background helper. Also silence non-linux cgroup stubs to keep warnings clean.
|
This is needed to fix |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee768e932c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
code-rs/tui/src/chatwidget.rs
Outdated
| if connecting_mcp && !w.test_mode { | ||
| // Render connecting status as a separate cell with standard gutter and spacing | ||
| w.history_push_top_next_req(history_cell::new_connecting_mcp_status()); | ||
| let message = history_cell::connecting_mcp_status_message(); | ||
| w.insert_background_event_early(message); |
There was a problem hiding this comment.
Using insert_background_event_early here means the notice is ordered with BackgroundOrderTicket::next_order (which sets output_index = i32::MAX) and OrderKey::cmp sorts by out ascending, so the “Connecting MCP servers…” cell will be placed after any user prompt and model output in that request. If a user submits a prompt before MCP setup completes, this notice will show up below their prompt/response instead of in the prelude where it used to appear, which is a visible ordering regression. Consider restoring history_push_top_next_req or inserting the background event without the MAX output_index so it stays above the first turn output.
Useful? React with 👍 / 👎.
|
I might make an issue instead, I'm having trouble with this one. basically the issue is that |
1 participant
Summary
experimental_resumewhen starting /new so a fresh session is createdTesting