Harden delete-mode validation and registry startup behavior#4
Open
Harden delete-mode validation and registry startup behavior#4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
DDIFF_REGISTRY_VOLUMEdoes not exist.-itand Podman networking may fail.deletecommand and--deleteonload) and provide an integration test that validates delete + GC flows.Description
Path(ddiff_register_volume).mkdir(parents=True, exist_ok=True)insiderun_registry()and remove-itfrom the run invocation to avoid interactive flags in non-TTY runs._request_manifest_digest()anddelete_image()functions to resolve a manifest digest, issue an HTTPDELETEto the registry, and triggerregistry garbage-collectviapodman/docker exec.--deletehandling toload(load_image(..., delete_after_load=True)) and register a new top-leveldeletecommand for explicit deletion.test/test_delete_mode.shwhich builds local images, starts a local registry with delete API enabled, generates a diff archive, verifiesddiff delete <tag>, and verifiesddiff load --deleteremoves the manifest; the script also improves registry image detection and pre-creates registry volume dirs.README.mdto document the server delete behaviour and theload/deleteusage.Testing
python3 -m py_compile ddiff.pywhich completed successfully.bash -n test/test_delete_mode.shwhich passed../test/test_delete_mode.shin this environment which exercises the updated flows but exited withSKIPbecause Podman networking namespace setup is not permitted here (setns: IO error: Operation not permitted), and the test correctly reports SKIP by design rather than a failure.Codex Task