feat: parse power measurements in http-power and add a power read CLI command#790
feat: parse power measurements in http-power and add a power read CLI command#790mmahut wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughHTTP Power driver's dummy ChangesHTTP Power JSON Parsing and CLI Integration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Previously the http-power driver's
read()always returned dummy(0.0, 0.0)values.read()now parses the JSON the read endpoint returns and pulls voltage/current out of it. By default it looks for top-levelvoltage/currentkeys, but you can pointvoltage_path/current_pathat a dotted path (emeter.voltage,StatusSNS.ENERGY.Voltage,meters.0.voltage) for devices that nest them.Tested against a real Shelly Plug S Gen3.