Skip to content

test: add e2e regression tests for router graceful shutdown#724

Draft
raballew wants to merge 1 commit into
jumpstarter-dev:mainfrom
raballew:e2e-lease-duration-tests
Draft

test: add e2e regression tests for router graceful shutdown#724
raballew wants to merge 1 commit into
jumpstarter-dev:mainfrom
raballew:e2e-lease-duration-tests

Conversation

@raballew

@raballew raballew commented Jun 1, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds e2e regression tests verifying the router deployment configuration prevents the failure patterns described in Updating the router kills existing connections #28
  • Tests cover rollout strategy (maxUnavailable=0, maxSurge>=1), readiness/liveness probes, preStop hook for connection draining, terminationGracePeriodSeconds, and health probe parity with the controller deployment
  • These tests will fail until the router deployment spec is updated to include graceful shutdown support

Closes #28

Test plan

  • Verify tests compile against the existing e2e suite
  • Run tests against a cluster with the current router deployment (expect failures documenting the gaps)
  • Run tests after implementing the router graceful shutdown changes (expect pass)

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 51f73a84-c338-4016-8e14-9880b9913b7a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Generated-By: Forge/20260601_152141_879822_af7227a0
@raballew raballew force-pushed the e2e-lease-duration-tests branch from cf3dd4d to b72cd20 Compare June 1, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updating the router kills existing connections

1 participant