Forward the new juliati options through the reusable workflow - #7
Draft
davidanthoff wants to merge 1 commit into
Draft
Forward the new juliati options through the reusable workflow#7davidanthoff wants to merge 1 commit into
davidanthoff wants to merge 1 commit into
Conversation
julia-run-testitems gained junit-path, coverage-lcov-path, output-mode, threads, gc-between-testitems, memory-threshold and schedule, but this workflow forwarded only testitem-timeout, filter, env and github_job_prep_script — so anyone using the shared workflow could not reach any of them. Added as plain inputs rather than getting the per-trigger override treatment. Those overrides exist for varying how much gets tested on a draft PR versus main; these describe how the test processes behave and do not sensibly differ by trigger. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
julia-actions/julia-run-testitemsgained seven inputs (julia-actions/julia-run-testitems#2), but this workflow forwarded onlytestitem-timeout,filter,envandgithub_job_prep_script— so anyone using the shared workflow could not reach any of them.Found while documenting the new options: the docs agent correctly declined to write them up for the shared workflow, because doing so would have documented inputs that silently did nothing.
Forwarded
junit-path,coverage-lcov-path,output-mode,threads,gc-between-testitems,memory-threshold,schedule.Added as plain inputs, not per-trigger
The
draft-pr-/pr-/main-/manual-trigger-override pattern exists for varying how much gets tested depending on the trigger — matrix breadth, the test filter, the timeout. These seven describe how the test processes behave, and do not sensibly differ between a draft PR and main. Adding 35 more input declarations for a need that has not appeared would be noise; the pattern is there to extend if it ever does.Verification
The workflow parses, all seven inputs are declared, and all seven reach the
julia-run-testitemsstep — 13 inputs forwarded in total, checked programmatically rather than by eye. README documents each one and notes why they have no per-trigger variants.🤖 Generated with Claude Code