Skip to content

fix: create websockets ConnectionClosed error correctly #1255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jujubot merged 3 commits into from
Mar 18, 2025
Merged

fix: create websockets ConnectionClosed error correctly #1255

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d670e79
fix: create websockets ConnectionClosed error correctly
james-garner-canonical Mar 12, 2025
ec3420f
test: update mock websocket's use of ConnectionClosed
james-garner-canonical Mar 12, 2025
416de02
fix: raise ConnectionClosed subtypes, correctly (+ update test raise)
james-garner-canonical Mar 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion juju/model/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1169,7 +1169,7 @@ def done():

await utils.block_until(done, timeout=timeout, wait_period=wait_period)
if _disconnected():
raise websockets.ConnectionClosed(1006, "no reason")
raise websockets.ConnectionClosed()

@property
def tag(self):
Expand Down