Skip to content

[FIX] Allow for proper metadata routing#298

Merged
fraimondo merged 9 commits intomainfrom
fix/metadata_routing
Mar 4, 2026
Merged

[FIX] Allow for proper metadata routing#298
fraimondo merged 9 commits intomainfrom
fix/metadata_routing

Conversation

@fraimondo
Copy link
Copy Markdown
Contributor

Some (custom) models might require more than X and y in the fit params, which, using the new scikit-learn API, should enable and configure metadata routing.

This PR takes care of that, so julearn is always on metadata routing.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 16, 2026

Codecov Report

❌ Patch coverage is 76.74419% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.92%. Comparing base (90c95d2) to head (fb860df).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
julearn/api.py 64.70% 3 Missing and 3 partials ⚠️
julearn/model_selection/final_model_cv.py 71.42% 1 Missing and 1 partial ⚠️
julearn/prepare.py 71.42% 1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (76.74%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   90.32%   89.92%   -0.40%     
==========================================
  Files          58       58              
  Lines        2770     2800      +30     
  Branches      491      497       +6     
==========================================
+ Hits         2502     2518      +16     
- Misses        172      181       +9     
- Partials       96      101       +5     
Flag Coverage Δ
docs 100.00% <ø> (ø)
julearn 89.92% <76.74%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
julearn/conftest.py 94.82% <100.00%> (+0.18%) ⬆️
julearn/pipeline/pipeline_creator.py 90.36% <100.00%> (+0.11%) ⬆️
julearn/utils/testing.py 88.88% <100.00%> (+0.48%) ⬆️
julearn/model_selection/final_model_cv.py 90.47% <71.42%> (-9.53%) ⬇️
julearn/prepare.py 91.57% <71.42%> (-0.92%) ⬇️
julearn/api.py 88.70% <64.70%> (-1.74%) ⬇️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 16, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-03-04 12:05 UTC

@fraimondo fraimondo requested a review from synchon March 4, 2026 10:34
Comment thread julearn/api.py Outdated
@fraimondo fraimondo force-pushed the fix/metadata_routing branch from d02ef73 to e62b7ef Compare March 4, 2026 11:23
@fraimondo fraimondo requested a review from synchon March 4, 2026 11:27
@fraimondo fraimondo merged commit 92ed90a into main Mar 4, 2026
22 of 23 checks passed
@fraimondo fraimondo deleted the fix/metadata_routing branch March 4, 2026 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants