Improve error handling in JSONAPI deserializer#139
Merged
richmolj merged 2 commits intojsonapi-suite:masterfrom Sep 10, 2018
Merged
Conversation
1) Add conditional checks for `@payload` and `data` to not return nils 2) Print a warning when Content-Type header is set to something other than what JSONAPI expects to lead the developer in the right direction to fix the issue.
Contributor
Author
|
I think this handles the situation a bit more cleanly and doesn't need the extra req.method checks that #50 has. For GET/HEAD requests, there isn't a body to deserialize, so those extra checks on the req.method would never be invoked as best as I can tell. Also, as a friend has been bitten multiple times by forgetting to set the content-type header in Postman, I felt a warning there was appropriate. If you would prefer that be a hard error instead of the warning, happy to make that change. |
Contributor
Contributor
|
Released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@payloadanddatato not return nils