add support for Django 5.0 and Python 3.12

[sarahboyce]

Hello 👋 firstly thank you so much for this package!

As Django 5.0 beta is released (and 5.0 will be released in December), this is hopefully some of the prep work for testing against 5.0. Understand though if you want to wait until the final version is released.

[jschneier]

Thanks for the PR. I'm looking forward to dropping everything before 4.2 in accordance with the guidelines put forth by upstream once it is released.

[sarahboyce]

Looks like some dependencies are not depreciation free for Python 3.12 (such as dateutil dateutil/dateutil#1314)
Should I remove 3.12 from the test matrix? 🤔

[jschneier]

Looks like some dependencies are not depreciation free for Python 3.12 (such as dateutil dateutil/dateutil#1314) Should I remove 3.12 from the test matrix? 🤔

I'm not overly bothered by the deprecation warnings, it seems like the actual failure comes from not installing setuptools automatically into venv which seems to me like a dropbox library issue?

[sarahboyce]

I'm not overly bothered by the deprecation warnings, it seems like the actual failure comes from not installing setuptools automatically into venv which seems to me like a dropbox library issue?

Yeah you're right. I created an issue in the dropbox library here: dropbox/dropbox-sdk-python#483
Looks like it is maintained by a dropbox team so 🤞 hopefully they will take a look.

[adamchainz]

Thanks for doing this Sarah. @jschneier / @foarsitter could you approve the workflow to run?

[sarahboyce]

I have updated that dropbox tests should be skipped when testing Python 3.12 (ref dropbox/dropbox-sdk-python#483) as not currently supported 👍

[jschneier]

For Dropbox does it make sense to install setuptools into the test environment?

[sarahboyce]

For Dropbox does it make sense to install setuptools into the test environment?

I think (if I understand correctly) setuptools is already installed in the ci tests.

django-storages/.github/workflows/ci.yml

Line 66 in 029bcd7

pip install --upgrade setuptools

For me, the ideal solution is dropbox accepts this PR: dropbox/dropbox-sdk-python#484 and publish a new release on PyPi 🤞
I have faith they will but it might take some time

[jschneier]

The skipping Dropbox fix doesn't seem to work :|

[sarahboyce]

Sorry @jschneier I should have been testing against my fork from the start 🤦‍♀️
https://github.com/sarahboyce/django-storages/actions/runs/6978703418/job/18990596632?pr=1
I think this is working now 🤞

[jschneier]

Sorry @jschneier I should have been testing against my fork from the start 🤦‍♀️ https://github.com/sarahboyce/django-storages/actions/runs/6978703418/job/18990596632?pr=1 I think this is working now 🤞

No worries once this goes in the CI will not be blocked. Lint issue popped up from the fix but that should be the last bit.

[jschneier]

Thanks!