Open
Conversation
Blocking removes for animations makes for plenty of headaches and timing shenanigans. Let's not do that. Instead, store a reference to the generated element on the playlist and original arrays and use that as the selector for removal and highlighting.
Both methods take the arguments `index`, `media`, `playNow`. The `insert` method adds the `media` to the playlist immediately preceeding the specified `index`. The `replace` method `insert`s the `media`, then `remove`s the playlist entry that was previously at that position.
Contributor
|
This is generic notification that all users issuing pull requests must sign our CLA before we can consider merging with the jPlayer project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both methods take the arguments
index,media,playNow. Theinsertmethod adds themediato the playlist immediately preceedingthe specified
index. Thereplacemethodinserts themedia, thenremoves the playlist entry that was previously at that position.This PR depends on #151, and probably obsoletes #102.
I though I'd get this PR into the queue even though #151 has not been
reviewed yet - I'll rebase this if #151 is merged.