Open
Conversation
koenpunt
force-pushed
the
remove-snake-case
branch
2 times, most recently
from
745d7d2 to
e935a9a
Compare
these tests have been in here since the beginning without them being run.
this was unnecessary added complexity
koenpunt
force-pushed
the
remove-snake-case
branch
from
e935a9a to
e5645d1
Compare
|
Why would anyone ever want to disable snake case? It's far more readable than camel case. Try reading these two function names, and see which one allows your eyes to move more quickly: There's no contest. The first one requires you to move very slowly to find the (imaginary/invisible) word breaks. The second one is almost as fast as reading normal English text with spaces. Because we spend more time reading code more than we spend writing code, it makes sense to move to snake case and away from camel case as often as circumstances permit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reenables two accidentally disabled tests. This also removes the OCD snake_case patch that once was introduced.