Skip to content

Update dependencies, social icons, and PR deploys - #10

Merged
joshymcd merged 3 commits into
mainfrom
t3code/286c7c6d
Jun 21, 2026
Merged

Update dependencies, social icons, and PR deploys#10
joshymcd merged 3 commits into
mainfrom
t3code/286c7c6d

Conversation

@joshymcd

@joshymcd joshymcd commented Jun 20, 2026

Copy link
Copy Markdown
Owner

Summary

  • update Bun dependencies to current compatible versions
  • replace Lucide brand icons with package-backed SVG data for GitHub, LinkedIn, and X/Twitter
  • add a reusable SocialIcon component for footer and find-me social links
  • enable SST Console autodeploy PR environments using pr- stages for PRs targeting main
  • keep Astro on latest v5 because latest astro-sst does not build with Astro 6

Verification

  • bun outdated
  • bun run build

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades several dependencies and introduces a new SocialIcon component to render inline SVGs instead of importing individual Lucide icons directly. The review feedback suggests defining a Props interface for the SocialIcon component to improve type safety and using as const on the socialLinks array to ensure correct literal type inference for the icon names.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +1 to +2
---
const { name, size = 24, class: className, ...attrs } = Astro.props;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Adding a Props interface to the SocialIcon component improves type safety and provides autocomplete in editors. It also prevents potential TypeScript compilation errors when indexing the icons object with a dynamic name string.

---
interface Props {
  name: "github" | "linkedin" | "twitter";
  size?: number;
  class?: string;
  [key: string]: any;
}

const { name, size = 24, class: className, ...attrs } = Astro.props;

Comment on lines 4 to 20
const socialLinks = [
{
href: "https://github.com/joshymcd", // Replace with your GitHub URL
label: "GitHub",
icon: Github,
icon: "github",
},
{
href: "https://linkedin.com/in/joshmcdonald92", // Replace with your LinkedIn URL
label: "LinkedIn",
icon: Linkedin,
icon: "linkedin",
},
{
href: "https://x.com/joshymcd92", // Replace with your X/Twitter URL
label: "Twitter", // Changed label
icon: Twitter, // Changed icon from X to Twitter
icon: "twitter",
},
];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using as const on the socialLinks array ensures that the icon property is inferred as the literal types "github" | "linkedin" | "twitter" instead of a generic string. This prevents TypeScript type mismatch errors when passing link.icon to the typed SocialIcon component.

const socialLinks = [
  {
    href: "https://github.com/joshymcd", // Replace with your GitHub URL
    label: "GitHub",
    icon: "github",
  },
  {
    href: "https://linkedin.com/in/joshmcdonald92", // Replace with your LinkedIn URL
    label: "LinkedIn",
    icon: "linkedin",
  },
  {
    href: "https://x.com/joshymcd92", // Replace with your X/Twitter URL
    label: "Twitter", // Changed label
    icon: "twitter",
  },
] as const;

@joshymcd joshymcd changed the title Update dependencies Update dependencies, social icons, and PR deploys Jun 20, 2026
@joshymcd
joshymcd merged commit 1ab5c06 into main Jun 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant