fix: add aria-label to custom variable inputs for screen reader acces…#129
Open
sh1vam31 wants to merge 1 commit intojoplin:masterfrom
Open
fix: add aria-label to custom variable inputs for screen reader acces…#129sh1vam31 wants to merge 1 commit intojoplin:masterfrom
sh1vam31 wants to merge 1 commit intojoplin:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #121
When a template with custom variables was used, the input fields in the
popup dialog had no
aria-labelattributes. This caused screen readerslike NVDA and VoiceOver to announce fields without names, e.g.:
Fix
Added
aria-labelattribute to all 6 custom variable input types:<input type="text"><input type="number"><input type="date"><input type="time"><select><select>(dropdown)Testing
Tested manually using macOS VoiceOver (⌘ + F5):
Before fix: VoiceOver said "stepper", "pop up button" with no field names.
After fix: VoiceOver correctly announces field names: