Skip to content

Add new-growing-products-in-category skill#8

Open
norightsforlis wants to merge 2 commits into
joomcode:mainfrom
norightsforlis:add-new-growing-products-in-category
Open

Add new-growing-products-in-category skill#8
norightsforlis wants to merge 2 commits into
joomcode:mainfrom
norightsforlis:add-new-growing-products-in-category

Conversation

@norightsforlis

Copy link
Copy Markdown
Contributor

Summary

Adds the new-growing-products-in-category skill: Finds new, already-selling listings in a category (recently listed, well rated, with real sales) as a product table.

Lives in skills/new-growing-products-in-category/SKILL.md and is registered in the README skills table. Public behavior and user-visible workflow only — no internal service names, schema, or implementation details.

Public-Safety Checklist

  • No credentials, tokens, keys, or secrets.
  • No internal filesystem paths.
  • No private Slack, Jira, Notion, admin, or service URLs.
  • No private service names or implementation details.
  • No customer data or private product data.
  • Skill directory name matches SKILL.md frontmatter name.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@profunctor

Copy link
Copy Markdown
Collaborator

KISS review: a few behavior issues before merge.

  1. README says listings have “real sales”, but the skill correctly says sales/revenue are JoomPulse estimates, not transactions. Please change that to “estimated sales” or “traction”.
  2. The skill points users to high-demand low-quality and gap-analysis, but those skills are not present in this PR’s target branch. Please remove those handoffs or merge them together.
  3. The workflow filters/sorts by estimated monthly sales, but the required table only shows weekly sales/revenue. Please either include monthly estimated sales in the table or use weekly metrics consistently.

@profunctor

Copy link
Copy Markdown
Collaborator

Review — new-growing-products-in-category

Summary: For a single Mercado Livre (Brasil) category, returns recently-listed listings that are already selling — filtered by three overridable thresholds (on-air age < ~30 days, rating > 3, > ~30 est. monthly sales), sorted strongest-first by est. monthly sales. Markdown product table with per-listing JoomPulse links, optional cards/bar chart, and a bilingual estimates disclaimer. Read-only.

Findings:

  • minor — Dangling cross-reference to a non-existent "high-demand low-quality skill" (frontmatter + body). Note: the gap-analysis reference is already an accepted forward-reference used by existing skills, but "high-demand low-quality" is unique to this PR and reads as resolvable. Drop it or mark it as planned.
  • minor — Frontmatter description is very long, packing scope, all three thresholds, triggers, the caveat, and three see-also pointers; the trailing cross-references add triggering noise. Move see-also out of the description (they're already in the body).
  • nit — Output spec inconsistency: table columns are weekly est. sales/revenue, but the sort key (Step 2.3) and cards use monthly sales. Both are retrieved, but the ranking is driven by an unshown figure. Surface the sort metric or align the two.
  • nit — README row omits the threshold definitions that define the skill; cosmetic.

Structure, directory name == name, bilingual triggers, disclaimer, and guardrails match product-change-monitor closely. No hardcoded IDs, secrets, internal service names, broken queries, or unsafe operations. Nothing blocking; the dangling reference is the main item.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants