Skip to content

Add top-keywords-in-my-category skill#15

Open
norightsforlis wants to merge 2 commits into
joomcode:mainfrom
norightsforlis:add-top-keywords-in-my-category
Open

Add top-keywords-in-my-category skill#15
norightsforlis wants to merge 2 commits into
joomcode:mainfrom
norightsforlis:add-top-keywords-in-my-category

Conversation

@norightsforlis

Copy link
Copy Markdown
Contributor

Summary

Adds the top-keywords-in-my-category skill: Lists a category's top trending Mercado Livre search keywords with each term's rank and how many products compete for it (real search-trend data).

Lives in skills/top-keywords-in-my-category/SKILL.md and is registered in the README skills table. Public behavior and user-visible workflow only — no internal service names, schema, or implementation details.

Public-Safety Checklist

  • No credentials, tokens, keys, or secrets.
  • No internal filesystem paths.
  • No private Slack, Jira, Notion, admin, or service URLs.
  • No private service names or implementation details.
  • No customer data or private product data.
  • Skill directory name matches SKILL.md frontmatter name.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@profunctor

Copy link
Copy Markdown
Collaborator

KISS review: two behavior issues worth fixing before merge.

  1. The new skill routes adjacent requests to opportunity-index and top-sellers, but those skills are not present in this catalog, so installed agents can promise unavailable handoffs. Please remove those references or add the skills in the same PR.
  2. The output says to respond in the seller's language, but the required table headers are hard-coded in pt-BR. Please make the table headers translatable or mark them as the pt-BR default only.

@profunctor

Copy link
Copy Markdown
Collaborator

Review — top-keywords-in-my-category

Summary: Read-only skill returning the top trending Mercado Livre (Brasil) search keywords for a named category — each with search-trend rank and a competing-product count — as a markdown table (Posição / Palavra-chave / Produtos), with optional cards + bar chart. It correctly treats this as real search-trend data (not a JoomPulse estimate) and drops the sales-estimate disclaimer.

Findings:

  • major — Dangling references to non-existent skills. The frontmatter and body defer to "the opportunity-index skill" and "the top-sellers skill"; neither exists in the repo. Also inconsistent with the repo convention of cross-referencing by descriptive phrase rather than literal slug. Remove or rephrase until those skills land.
  • minor — Vestigial copy-paste rule: the Visualization section says "any column with movement uses a word header, never a bare Δ", but this table has no movement/delta columns. Drop it.
  • minor — The new "Visualization" section has no precedent among the existing three skills; worth a maintainer sign-off so future skills follow the same pattern.
  • nit — "Competing-product count" semantics are slightly loose (active offers? total matching listings?) given the "real data, not estimate" framing.

Frontmatter, directory name, README row, read-only/pt-BR defaults, and guardrails all match the house style. No secrets or unsafe operations.

…al delta rule

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants