feat(scheduling): add Queue tab with provider lanes and execution analytics by jonit-dev · Pull Request #86 · jonit-dev/night-watch-cli

jonit-dev · 2026-03-13T16:47:08Z

Summary

This PR completes the Provider-Aware Queue implementation (Phase 4 of the Provider-Aware Weighted Scheduling PRD).

Changes

Scheduling Page Queue Tab: Added a new 'Queue' tab to the Scheduling page that visualizes:
- Queue Overview Card: Shows running count, pending count, average wait time, and oldest pending age
- Provider Lanes Chart: Visualizes running and pending jobs grouped by provider bucket
- Provider Bucket Summary: Shows running/pending counts per provider bucket
- Recent Runs Chart: Displays last 24 hours of job executions with status, duration, and wait time

Implementation Status

The Provider-Aware Queue PRD phases 1-3 were already implemented:

Phase 1 (Queue Dispatch Correctness): ✅ Jobs rebuild env from queued project config
Phase 2 (Provider-Aware Scheduler): ✅ Provider bucket resolution and capacity checks
Phase 3 (Operational Telemetry): ✅ Job runs table and analytics APIs

This PR adds the Phase 4 UI components to visualize the queue state.

Test plan

yarn verify passes
All existing tests pass
Manual: Open Scheduling page, verify Queue tab shows correct data

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com

github-actions · 2026-03-13T16:47:43Z

DiffGuard AI Analysis

AI Review Summary

🏆 Overall Score: 82/100

The PR adds a comprehensive Queue tab to the Scheduling page with four well-organized cards displaying queue status, provider lanes, bucket summaries, and recent runs. The implementation follows existing patterns well but has minor UX and robustness gaps.

✅ Key Strengths

Consistent Code Style: Follows existing patterns in the file, including import conventions with .js extensions and Card component usage.
Defensive Null Handling: Proper use of optional chaining (queueStatus?.running, queueAnalytics?.averageWaitSeconds) prevents runtime errors when data is loading.
Logical Component Composition: New tab integrates seamlessly with existing tab structure and reuses queueStatus and queueAnalytics data already fetched by the parent component.

⚠️ Areas for Improvement

Time Display Formatting: Times over 60 minutes display as raw minutes (e.g., "90m" instead of "1h 30m"). Consider a utility function to format durations more readably for better UX.
Error State Handling: Only loading states are shown; consider adding error handling UI for cases where queueStatus or queueAnalytics fail to load.
Hardcoded Running Job Count: queueStatus?.running ? 1 : 0 assumes single-job execution. If the system supports parallel jobs, this logic may need adjustment or clarification.

📋 Issues Found

Issue Type	Issue Name	Affected Components	Description	Impact/Severity
Maintainability	Missing Error Boundaries	`web/pages/Scheduling.tsx` (Queue tab)	No error UI for failed data fetches—users see only loading text indefinitely if requests fail.	Low
UX	Time Format Readability	Queue Overview Card	Large wait times display as large minute counts (e.g., "120m") rather than human-readable hours.	Low

🔚 Conclusion

This is a clean, well-structured feature addition that integrates smoothly with existing code. No blocking issues found—only minor UX polish and robustness enhancements worth considering. Ready to merge with optional follow-ups.

Analyzed using z-ai/glm-5

jonit-dev

AI Review Summary

🏆 Overall Score: 88/100

The PR adds a comprehensive Queue tab to the Scheduling page with four well-organized cards displaying queue status, provider lanes, bucket summaries, and recent runs. The implementation follows existing patterns and integrates cleanly with the existing data fetching logic.

✅ Key Strengths

Clean Component Architecture: The three new chart components (ProviderLanesChart, ProviderBucketSummary, RecentRunsChart) are well-typed with proper interfaces and follow the project's existing patterns.
Defensive Null Handling: Proper use of optional chaining (queueStatus?.running, queueAnalytics?.averageWaitSeconds) prevents runtime errors when data is loading.
Consistent Code Style: Follows existing conventions including .js import extensions, Card component usage, and Tailwind CSS styling patterns.

⚠️ Areas for Improvement

Time Display Formatting: Times over 60 minutes display as raw minutes (e.g., "90m" instead of "1h 30m"). Consider a utility function like formatDuration() used in RecentRunsChart to format durations more readably in the Queue Overview card.
Hardcoded Running Job Count: queueStatus?.running ? 1 : 0 assumes single-job execution. If the system supports parallel jobs, this logic may need adjustment.

📋 Issues Found

Issue Type	Issue Name	Affected Components	Description	Impact/Severity
UX	Time Format Readability	Queue Overview Card	Large wait times display as large minute counts (e.g., "120m") rather than human-readable hours.	Low
Maintainability	Hardcoded Running Count	`web/pages/Scheduling.tsx:789`	Assumes single concurrent job; may break if parallel execution is enabled.	Low

🔚 Conclusion

This is a clean, well-structured feature addition that integrates smoothly with existing code. The failing CI tests (core-flow-smoke) return exit code 127 (command not found), which is a pre-existing CI environment issue unrelated to these UI changes. Ready to merge.

🔍 Reviewed by GLM-5

jonit-dev · 2026-03-25T23:49:04Z

✅ Ready for Human Review

Night Watch has reviewed this PR (score: 82/100) and found no issues requiring automated fixes.

This PR is ready for human code review and merge.

github-actions · 2026-03-26T02:08:42Z

DiffGuard AI Analysis

AI Review Summary

🏆 Overall Score: 82/100

This PR adds a new "Queue" tab to the Scheduling page with four informational cards displaying queue status and analytics. The implementation is clean, follows existing patterns, and uses proper null-safety throughout.

✅ Key Strengths

Defensive Programming: Consistent use of optional chaining (queueStatus?.running) and nullish coalescing (?? 0) prevents runtime errors when data is unavailable.
Loading States: Each card properly handles the loading state with helpful placeholder text while data is being fetched.
Component Composition: New chart components (ProviderLanesChart, ProviderBucketSummary, RecentRunsChart) are cleanly imported and composed, maintaining separation of concerns.

⚠️ Areas for Improvement

Inline JSX in Tabs Array: The ~100 lines of inline JSX inside the tabs array reduce readability. Consider extracting the Queue tab content to a separate QueueTab component or a memoized variable.
Missing Error Handling: The cards only handle loading states, not error states. Consider adding error UI for when queueStatus or queueAnalytics requests fail.
Tabs Array Recreation: The tabs array is recreated on every render. Consider wrapping with useMemo to avoid unnecessary object allocation, especially given the large inline content.

📋 Issues Found

Issue Type	Issue Name	Affected Components	Description	Impact/Severity
Maintainability	Inline Tab Content	`Scheduling.tsx`	Large inline JSX block in tabs array makes the file harder to navigate and maintain.	Medium
Testing	Missing Test Coverage	`Scheduling.tsx`	No test file changes included to verify the new Queue tab renders correctly.	Low
Performance	Array Recreation	`Scheduling.tsx:1026+`	The tabs array with large content objects is recreated on every component render.	Low

🔚 Conclusion

This is a solid, well-structured addition that follows existing codebase patterns. The main concerns are maintainability due to the large inline JSX and the absence of error handling states. Consider extracting the Queue tab content and adding useMemo before merging, though neither is strictly blocking.

Analyzed using z-ai/glm-5

jonit-dev · 2026-03-26T18:54:54Z

Night Watch QA Report

Changes Classification

Type: UI
Files changed: 1

Test Results

UI Tests (Playwright)

Status: Skipped (11 tests)
Tests: 11 test(s) in 1 file(s)
Note: Tests require running backend API. Tests skip gracefully when API is unavailable.

Unit Tests (Vitest)

Status: All passing (4/4)
Tests: 4 test(s) in 1 file(s)
- renders Queue tab with provider lanes and execution analytics ✓
- shows loading state in Queue tab when data is being fetched ✓
- displays queue stats when queue has running job ✓
- keeps cron controls available after dashboard refresh ✓

Test Files Added

web/tests/e2e/qa/qa-scheduling-queue-tab.spec.ts - E2E tests for Queue tab UI
web/pages/__tests__/Scheduling.test.tsx - Updated with Queue tab unit tests

Test Coverage

The tests cover:

Queue tab button visibility
Queue Overview section (Running, Pending, Avg Wait, Oldest Pending stats)
Provider Lanes section with job type color legend
Provider Buckets section
Recent Runs section
Tab switching between Schedules and Queue
Loading states when data is being fetched

Artifacts

Screenshots and videos captured in web/test-results/ directory (not committed due to size).

Night Watch QA Agent

🧪 QA run by GLM-5

jonit-dev · 2026-03-26T23:49:04Z

✅ Ready for Human Review

Night Watch has reviewed this PR (score: 85/100) and found no issues requiring automated fixes.

This PR is ready for human code review and merge.

jonit-dev · 2026-03-27T02:49:06Z

✅ Ready for Human Review

Night Watch has reviewed this PR (score: 85/100) and found no issues requiring automated fixes.

This PR is ready for human code review and merge.

jonit-dev · 2026-03-27T23:49:04Z

✅ Ready for Human Review

Night Watch has reviewed this PR (score: 85/100) and found no issues requiring automated fixes.

This PR is ready for human code review and merge.

jonit-dev · 2026-03-28T05:49:05Z

✅ Ready for Human Review

Night Watch has reviewed this PR (score: 85/100) and found no issues requiring automated fixes.

This PR is ready for human code review and merge.

…lytics Adds a new 'Queue' tab to the Scheduling page that visualizes: - Queue overview (running, pending, avg wait, oldest pending) - Provider lanes chart showing jobs grouped by provider bucket - Provider bucket summary with running/pending counts - Recent runs chart with execution history This completes Phase 4 of the Provider-Aware Queue PRD. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Extract nested ternary into if-else chain in review.ts - Fix import sorting in config.ts Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

… use useMemo - Extract Queue tab content to separate QueueTab.tsx component for better maintainability - Add error states for queueStatus and queueAnalytics with proper error UI - Wrap tabs array in useMemo to prevent unnecessary recreation on each render - Add tests for Queue tab rendering and error states Addresses review feedback on PR #86. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

- Fix TypeScript errors in Scheduling.test.tsx by using correct property names (enqueuedAt instead of createdAt, projectPath instead of projectName, removed completed from byProviderBucket) - Add fake claude binary to PATH in core-flow-smoke tests to fix exit code 127 errors in reviewer tests Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

jonit-dev commented Mar 25, 2026

View reviewed changes

jonit-dev force-pushed the night-watch/provider-aware-queue branch from f977cb5 to 8702b77 Compare March 26, 2026 02:07

jonit-dev force-pushed the night-watch/provider-aware-queue branch from 53b69b7 to 0a29338 Compare March 28, 2026 21:39

jonit-dev added the ready-to-merge PR is ready to merge label Mar 28, 2026

Test User and others added 3 commits March 29, 2026 03:54

fix: resolve lint errors in review.ts and config.ts

87f9d64

- Extract nested ternary into if-else chain in review.ts - Fix import sorting in config.ts Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(scheduling): add Queue tab with provider lanes and execution analytics#86

feat(scheduling): add Queue tab with provider lanes and execution analytics#86
jonit-dev wants to merge 4 commits intomasterfrom
night-watch/provider-aware-queue

jonit-dev commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

jonit-dev left a comment

Uh oh!

jonit-dev commented Mar 25, 2026

Uh oh!

github-actions bot commented Mar 26, 2026

Uh oh!

jonit-dev commented Mar 26, 2026

Uh oh!

jonit-dev commented Mar 26, 2026

Uh oh!

jonit-dev commented Mar 27, 2026

Uh oh!

jonit-dev commented Mar 27, 2026

Uh oh!

jonit-dev commented Mar 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

jonit-dev commented Mar 13, 2026

Summary

Changes

Implementation Status

Test plan

Uh oh!

github-actions bot commented Mar 13, 2026

DiffGuard AI Analysis

AI Review Summary

✅ Key Strengths

⚠️ Areas for Improvement

📋 Issues Found

🔚 Conclusion

Uh oh!

jonit-dev left a comment

Choose a reason for hiding this comment

AI Review Summary

✅ Key Strengths

⚠️ Areas for Improvement

📋 Issues Found

🔚 Conclusion

Uh oh!

jonit-dev commented Mar 25, 2026

✅ Ready for Human Review

Uh oh!

github-actions bot commented Mar 26, 2026

DiffGuard AI Analysis

AI Review Summary

✅ Key Strengths

⚠️ Areas for Improvement

📋 Issues Found

🔚 Conclusion

Uh oh!

jonit-dev commented Mar 26, 2026

Night Watch QA Report

Changes Classification

Test Results

UI Tests (Playwright)

Unit Tests (Vitest)

Test Files Added

Test Coverage

Artifacts

Uh oh!

jonit-dev commented Mar 26, 2026

✅ Ready for Human Review

Uh oh!

jonit-dev commented Mar 27, 2026

✅ Ready for Human Review

Uh oh!

jonit-dev commented Mar 27, 2026

✅ Ready for Human Review

Uh oh!

jonit-dev commented Mar 28, 2026

✅ Ready for Human Review

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant