fix(Sylius): Fix rename directory when there are no media#116
Open
loic425 wants to merge 2 commits into
Open
Conversation
loic425
force-pushed
the
fix/rename-directory
branch
from
0ca4ecc to
2f318df
Compare
# Conflicts: # src/Bridge/Sylius/public/entrypoints.json # src/Bridge/Sylius/public/joli-media-sylius-admin.fda347e3.js # src/Bridge/Sylius/public/manifest.json # src/Bridge/Sylius/templates/admin/shared/layout/base/scripts.html.twig
loic425
force-pushed
the
fix/rename-directory
branch
from
2f318df to
374fccc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rename directory button was not working on empty directory like this:
The form always had the "d-none" class.
This PR fixes that issue and the redirection when we are currently on the folder we are editing.