-
Notifications
You must be signed in to change notification settings - Fork 39
First commit. Wanted to commit the passing minimum of 7/10 before tak… #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IvanCastillo1986
wants to merge
3
commits into
joinpursuit:master
Choose a base branch
from
IvanCastillo1986:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
972fad3
First commit. Wanted to commit the passing minimum of 7/10 before tak…
IvanCastillo1986 a8c44d5
Second commit. Still have one problem unsolved
IvanCastillo1986 8cd5514
Final commit, passed every test. Learned my way through array method …
IvanCastillo1986 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,8 +10,36 @@ | |
| * | ||
| */ | ||
|
|
||
| function getCountriesSortedByPopulation() { | ||
|
|
||
| // takes in an array with objects holding a country as key and it's population number as value | ||
| // need to return country names with lowest to highest population | ||
| // will sort population number from lowest to highest | ||
| // will access the property values with arr.country | ||
| // | ||
| function getCountriesSortedByPopulation(arr) { | ||
| let newObj = {} | ||
| for (let element in arr) { | ||
| newObj[element] = arr[element] | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider what 'element' is, which information you need from the element, and which array method allows you to add data into the array you are going to return. |
||
| } | ||
| return newObj | ||
| } | ||
|
|
||
| console.log(getCountriesSortedByPopulation([ | ||
| { | ||
| country: "Algeria", | ||
| population: 41, | ||
| }, | ||
| { | ||
| country: "Belize", | ||
| population: 0.4, | ||
| }, | ||
| { | ||
| country: "China", | ||
| population: 1386, | ||
| }, | ||
| { | ||
| country: "Denmark", | ||
| population: 6, | ||
| }, | ||
| ])) | ||
|
|
||
| module.exports = getCountriesSortedByPopulation | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function should return an array, not an object.