Converge the test suite: delete dead probes, promote live contracts, harden soft checks#71
Merged
Merged
Conversation
…tracts to the gate Delete 17 test files (~2500 lines) with no automated entry point: one-off profiling/bench scripts (cpu-profile, profile-*, *-bench, ab-emitted), stale smoke probes superseded by real gates (treesitter-smoke, monarch-smoke, verify-rejects, snapshot), and the token-DFA measurement spike plus its only consumer (src/token-dfa.ts). Remove src/trace-markers.ts alongside its only reader (exec-trace). Gate changes in check.ts: - drop core/sanity (no-throw only; strictly subsumed by conformance and issue-cases) and highlighter/html-lexer-spike (kept as gate:html-lexer script; its failures are covered by html-conformance + *-sites gates) - promote left-recursion, newline-mode, and interpolation-metadata: all three carry unique hard assertions for shipped features but previously ran only via package scripts or the local verify loop Harden html-embed-js: the official-grammar boundary comparison was report-only; now ratchets at 216/221 chars so boundary regressions fail. 44/44 gates pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the test-suite audit:
test/had 99 files (~18k lines), but 19 of them had no automated entry point and several gates were weak or redundant. This PR converges to the effective set without losing any hard assertion.Deleted (17 files + 2 orphaned src modules, −2,521 lines) — all had no entry point from
check.ts,package.json, or CI:cpu-profile,profile-lines,profile-vs-tsc,profile-vs-peers,profile-portable-peers,emit-parser-bench,ab-emitted,treesitter-yaml-bench, plus theoxc-parse-bench/andtsgo-parsebench/peer dirstreesitter-smoke,monarch-smoke,verify-rejects,snapshot,sanity-checktoken-dfa-verify+ its only consumersrc/token-dfa.ts) and the execution tracer (exec-trace+src/trace-markers.ts, whose markers nothing insrc/imports)Gate roster (43 → 44):
core/sanity(no-throw only, strictly subsumed) andhighlighter/html-lexer-spike(demoted to the existinggate:html-lexerscript; its failure modes are covered byhtml-conformance+self-close-sites+raw-text-case-sites)left-recursion,newline-mode,interpolation-metadata— unique hard contracts for shipped features that previously ran only via package scripts / the local verify loopHardened:
html-embed-js's comparison against the official VS Code HTML grammar was report-only; it now ratchets at 216/221 boundary chars (the 5 known divergences are the<script ...>-tail delegation difference), so real boundary regressions fail the gate.Deliberately kept:
yaml-issue12-regressions/yaml-depth-witnesses(hand-written hard regression locks, cheap) andcollect-conflicts(the documented tree-sitter conflict-closure workflow tool referenced fromsrc/gen-treesitter.ts).Test plan
npx tsc --noEmitcleannode test/check.ts— 44/44 gates passrgsweep: no dangling references to deleted files insrc/,test/,docs/,.github/,package.json