CI fix macOS FlexiBLAS build with newer CMake#223
Merged
ogrisel merged 9 commits intoJul 10, 2026
Conversation
Newer CMake versions reject the minimum policy version bundled with FlexiBLAS v3.4.2. Set CMAKE_POLICY_VERSION_MINIMUM=3.5 so the existing FlexiBLAS pin keeps working without upgrading the library. Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Remove the v3.4.2 checkout and its comment so CI builds the latest FlexiBLAS release from the default branch. Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Install ccache from conda-forge, wire it into the FlexiBLAS cmake build, and persist the cache directory across CI runs for both macOS and Linux flexiblas jobs. Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
FlexiBLAS 3.5 installs libflexiblas_mgmt as a separate shared library but does not embed a usable rpath in the flexiblas CLI. Set the install rpath during cmake configuration and export the library path for the post-install sanity check and subsequent build steps. Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Contributor
Author
|
Assuming CI is consistently green, this LGTM and I plan to merge. |
Contributor
Author
|
I am investigating the cause of the failure of the meta-test. |
Windows conda-forge MKL stacks now expose MKL as mkl_rt.<version>.dll instead of libblas.dll. The mkl_rt prefix remains covered by the parametrized tests. Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Revert filtering libblas out of test_threadpool_limits_by_prefix and instead whitelist the parametrized libblas cases in SAFE_SKIPPED_TESTS. Document that libblas.dll handling is legacy conda-forge Windows code that current stacks no longer exercise (MKL uses mkl_rt.<version>.dll). Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Contributor
Author
|
I plan to merge if CI is green. |
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Windows py39_pip CI runners report Cooperlake for the shipped libscipy_openblas wheel. Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes macOS
pylatest_flexiblasCI failure.Newer CMake on macOS runners rejects the minimum policy version in FlexiBLAS v3.4.2 bundled LAPACK sources during install. Adds
-DCMAKE_POLICY_VERSION_MINIMUM=3.5to the cmake invocation.This is taken from #203. However let's isolate the fixes in individual PRs to be able to incrementally fix the CI.