Optimize lexer, parser, and interpreter for speed#362
Open
marksmayo wants to merge 2 commits into
Open
Conversation
Reduce per-expression overhead across the compile and evaluation pipeline without changing behavior: - lexer: scan with a local index and slice identifier/number/string runs instead of char-by-char accumulation; consume whitespace runs; find-based scanning for quoted strings and literals. - parser: precompute per-class nud/led dispatch tables, inline token access and AST node construction on the hot path, and look up the compile cache without raising on a miss. - interpreter: share a pre-warmed default TreeInterpreter for default-options searches, cache resolved visit_* handlers, use a fixed two-argument visit signature, and short-circuit field access on None. - functions: resolve signature types to Python types once at registration and reuse the cached result during validation. Benchmarks (tests/compliance/benchmarks.json) improve 8-97% across lex/parse/search with no regressions; full test suite and hypothesis property tests pass.
Optimize lexer, parser, and interpreter for speed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduces per-expression overhead across the compile and evaluation pipeline with no change in behavior. Benchmarks in
tests/compliance/benchmarks.jsonimprove 8–97% across lex/parse/search with zero regressions.Changes
find-based scanning for quoted strings and literals.TreeInterpreterfor default-options searches, cache resolvedvisit_*handlers, use a fixed two-argumentvisitsignature, and short-circuit field access onNone.Compatibility
Public API (
search,compile,Options) and subclass extension points are preserved: overridingTreeInterpreter.visit/_is_false,Functions._validate_arguments, baseVisitorinstance-level/staticmethod handlers, andParser._error_nud_tokenall continue to work. The shared default interpreter's method cache is pre-warmed so concurrent default searches only read it (safe on free-threaded CPython builds).Testing