Return dummy metrics if ClickHouse host or URL is not set in Rotor#1251
Open
jberlyn wants to merge 1 commit intojitsucom:newjitsufrom
Open
Return dummy metrics if ClickHouse host or URL is not set in Rotor#1251jberlyn wants to merge 1 commit intojitsucom:newjitsufrom
jberlyn wants to merge 1 commit intojitsucom:newjitsufrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running without ClickHouse (e.g. local dev without the
clickhouseservice), rotor crashes on startup withCLICKHOUSE_HOST is not defined. This happens becausecreateMetrics()unconditionally callsgetClickhouseConfig(), which throws when neitherCLICKHOUSE_HOSTnorCLICKHOUSE_URLis set.This issue was raised by someone here:
#1243
Fix
eventsLoggeralready has a fallback for this case — it usesDummyEventsStorewhen ClickHouse env vars are absent (src/index.ts:77-81). This PR applies the same pattern to metrics by adding an early return increateMetrics()that yields the already-exportedDummyMetricswhen ClickHouse isn't configured.AI Usage Disclosure
I used Claude Code to analyze the rotor codebase and identify the root cause and the existing pattern used for
eventsLogger. The fix and this description are my own.