fix: pass draft flag when fetching parent documents for breadcrumb generation#62
Closed
fix: pass draft flag when fetching parent documents for breadcrumb generation#62
Conversation
…neration Co-authored-by: jhb-dev <20878653+jhb-dev@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix passing draft flag for parent document fetching
fix: pass draft flag when fetching parent documents for breadcrumb generation
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findByIDCachedingetBreadcrumbs.tsnever passeddraftwhen fetching parent documents, causing draft-only parents to be unfindable and stale published breadcrumbs to appear in preview mode.Changes
getBreadcrumbs.ts— Addeddraft?: booleanparameter; passes it tofindByIDCached. Cache key now includesdraft/publishedsuffix to prevent cross-contamination.setPageVirtualFields.ts— Addeddraft?: booleanparameter; threads it through togetBreadcrumbs.setVirtualFields.ts— AddeddraftFromRequesthelper that readsreq.query.draft(handles both"true"string from REST and booleantrue). BothsetVirtualFieldsBeforeReadandsetVirtualFieldsAfterChangederive and forward the flag.Draft detection
Draft context is derived from
req.query.draft, which Payload populates from the URL query string for REST requests (e.g. admin, live preview with?draft=true). Local API callers that need draft breadcrumbs can passreq: { query: { draft: 'true' } }.Tests
Added
describe('Draft flag is forwarded to parent document fetch during breadcrumb computation')in both localized and unlocalized test suites covering:draft: truereaches the nested parentfindByIDwhenreq.query.draft = 'true'draftunset (no regression)Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
telemetry.payloadcms.com/opt/hostedtoolcache/node/24.14.0/x64/bin/node /opt/hostedtoolcache/node/24.14.0/x64/bin/node --conditions node --conditions development --experimental-import-meta-resolve --require /home/REDACTED/work/payload-plugins/payload-plugins/pages/node_modules/.pnpm/vitest@4.0.18_@types+node@25.2.3_sass@1.77.4_tsx@4.21.0/node_modules/vitest/suppress-warnings.cjs /home/REDACTED/work/payload-plugins/payload-plugins/pages/node_modules/.pnpm/vitest@4.0.18_@types+node@25.2.3_sass@1.77.4_tsx@4.21.0/node_modules/vitest/dist/workers/forks.js(dns block)/opt/hostedtoolcache/node/24.14.0/x64/bin/node /opt/hostedtoolcache/node/24.14.0/x64/bin/node --conditions node --conditions development --experimental-import-meta-resolve --require /home/REDACTED/work/payload-plugins/payload-plugins/pages/node_modules/.pnpm/vitest@4.0.18_@types+node@25.2.3_sass@1.77.4_tsx@4.21.0/node_modules/vitest/suppress-warnings.cjs /home/REDACTED/work/payload-plugins/payload-plugins/pages/node_modules/.pnpm/vitest@4.0.18_@types+node@25.2.3_sass@1.77.4_tsx@4.21.0/node_modules/vitest/dist/workers/forks.js /home/REDACTED/woradd /home/REDACTED/wor. bash --no�� --noprofile /home/REDACTED/work/payload-plugins/payload-plugins/alt-text/src/plugin.ts /home/REDACTED/work/_temp/ghcca-node/node/bin/grep /home/REDACTED/worgit /home/REDACTED/worrev-parse /home/REDACTED/worHEAD grep(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.