Skip to content

Revert "AX-1792: Remove JFROG_URL validation from SessionStart injector" #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MatanEden1 merged 1 commit into from
Jul 7, 2026
Merged

Revert "AX-1792: Remove JFROG_URL validation from SessionStart injector" #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions plugin/scripts/inject-instructions.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,30 @@ if (forceDisabled) {
process.exit(0);
}

// Validate JFROG_URL early to surface misconfigurations before the MCP server
// attempts to connect and fails with a confusing DNS or double-slash error.
if (!process.env.JFROG_URL) {
const missingUrlWarning = "WARNING: JFROG_URL is not set. The JFrog MCP server will be unreachable — set JFROG_URL to your Artifactory base URL (e.g. https://mycompany.jfrog.io) and restart.";
log(missingUrlWarning);
process.stdout.write(JSON.stringify({
hookSpecificOutput: {
hookEventName: "SessionStart",
additionalContext: `IMPORTANT: Immediately tell the user: "${missingUrlWarning}"`,
},
}));
process.exit(0);
} else if (process.env.JFROG_URL.endsWith("/")) {
const trailingSlashWarning = "WARNING: JFROG_URL has a trailing slash. This produces a double-slash in the MCP URL and will silently fail — remove the trailing slash and restart.";
log(trailingSlashWarning);
process.stdout.write(JSON.stringify({
hookSpecificOutput: {
hookEventName: "SessionStart",
additionalContext: `IMPORTANT: Immediately tell the user: "${trailingSlashWarning}"`,
},
}));
process.exit(0);
}

if (forceEnabled) {
debug("Force-enable flag is set.");
} else if (!(await isAgentGuardEnabledViaSettings())) {
Expand Down
Loading