feat: create package alias for helm and updated integration tests#3591
Open
kumadee wants to merge 3 commits into
Open
feat: create package alias for helm and updated integration tests#3591kumadee wants to merge 3 commits into
kumadee wants to merge 3 commits into
Conversation
Allows intercepting helm CLI calls to be intercepted by jfrog CLI. We use helm-maven-plugin in our builds, which under the hood executes `helm dependency`, `helm package` and `helm push` commands. Without this feature we only have a dirty workaround to create a shim which mimics package aliasing feature in order to capture helm chart in a build-info. This allows us to keep using `helm-maven-plugin` and indirectly invoke `jf helm` to record the build-info along with maven artifacts. **Feature was originally requested as a support ticket 427008**
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
masterbranch.go vet ./....go fmt ./....Allows intercepting helm CLI calls to be intercepted by jfrog CLI.
We use helm-maven-plugin in our builds, which under the hood executes
helm dependency,helm packageandhelm pushcommands. Without thisfeature we only have a dirty workaround to create a shim which mimics
package aliasing feature in order to capture helm chart in a build-info.
This allows us to keep using
helm-maven-pluginand indirectly invokejf helmto record the build-info along with maven artifacts. Feature was originally requested as a jfrog support ticket 427008updated integration test for
jf helm packagerelates to
jf helm packagefails to collect build-info when Chart.yaml and packaged chart archive are in different directories. jfrog-cli-artifactory#501