Skip to content

fix: honor --skip-login on docker build #3396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joergsesterhenn wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: honor --skip-login on docker build #3396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions buildtools/cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1042,7 +1042,7 @@ func buildCmd(c *cli.Context) error {
}

// Extract build configuration and arguments
_, rtDetails, _, _, _, cleanArgs, buildConfiguration, err := extractDockerOptionsFromArgs(c.Args())
_, rtDetails, _, skipLogin, _, cleanArgs, buildConfiguration, err := extractDockerOptionsFromArgs(c.Args())
if err != nil {
return err
}
Expand All @@ -1051,12 +1051,14 @@ func buildCmd(c *cli.Context) error {
return err
}

// Login to the docker registry
err = loginCmd(c)
if err != nil {
return err
if !skipLogin {
// Login to the docker registry
err = loginCmd(c)
if err != nil {
return err
}
}

dockerOptions := strategies.DockerBuildOptions{
DockerFilePath: dockerFilePath,
PushExpected: pushOption,
Expand Down
Loading